From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8QVW-0005KZ-Ta for qemu-devel@nongnu.org; Fri, 26 Jun 2015 06:05:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z8QVS-0000SY-Jm for qemu-devel@nongnu.org; Fri, 26 Jun 2015 06:05:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41777) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8QVS-0000Qj-Eb for qemu-devel@nongnu.org; Fri, 26 Jun 2015 06:05:10 -0400 Message-ID: <558D23D1.9020204@redhat.com> Date: Fri, 26 Jun 2015 12:05:05 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <7d54c33fa2a928fd317f3a95af61f854f43ba23c.1435195913.git.zhugh.fnst@cn.fujitsu.com> <558C33BE.8020603@redhat.com> <558C3A53.3000901@suse.de> <20150626111941.4faf51f0@nial.brq.redhat.com> In-Reply-To: <20150626111941.4faf51f0@nial.brq.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RESEND PATCH v8 2/4] hw: add a wrapper for registering reset handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: chen.fan.fnst@cn.fujitsu.com, izumi.taku@jp.fujitsu.com, Zhu Guihua , qemu-devel@nongnu.org, ehabkost@redhat.com On 26/06/2015 11:19, Igor Mammedov wrote: > That's one of the reasons, I've asked to get rid of icc-bus. > > Another reason is to move default APIC MMIO mapping to CPU from board > and handle region remapping from CPU itself as it's supposed to be if CPU > would program another APIC base. > > Paolo, > would following change be acceptable: > > x86_cpu_realize() { > if (tcg) { > memory_region_add_subregion_overlap(cpu->as, apic->mr) > } else { > if (map_once) > memory_region_add_subregion_overlap(get_system_memory(), apic->mr) > } > } > still a hack but a localized to CPU Yes, this is better. Paolo