Re: [Qemu-devel] [PATCH] refresh filename after the node is replaced

[Max Reitz <mreitz@redhat.com>]

On 25.06.2015 08:41, Wen Congyang wrote:
> We can use block job mirror to repair broken quorum files. But the command
> 'info block' doesn't output correct filename after block job mirror finishes.

Which filename? The quorum filename is broken after this patch, too. In 
order to fix this, we need to call bdrv_refresh_filename() after 
bdrv_swap() on all BDSs which reference one of the swapped BDSs. I think 
this will not be reasonably possible until Kevin's "bdrv_reopen() 
overhaul" series is merged which introduces a generic parent-child 
relationship for BDSs.

Max

> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> ---
>   block/mirror.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/block/mirror.c b/block/mirror.c
> index 8aa2b21..2ca2c21 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -351,6 +351,9 @@ static void mirror_exit(BlockJob *job, void *opaque)
>               bdrv_set_backing_hd(s->base, NULL);
>               bdrv_unref(p);
>           }
> +        if (s->to_replace != s->common.bs) {
> +            bdrv_refresh_filename(s->common.bs);
> +        }
>       }
>       if (s->to_replace) {
>           bdrv_op_unblock_all(s->to_replace, s->replace_blocker);