qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Cc: "Peter Crosthwaite" <peter.crosthwaite@xilinx.com>,
	"Alex Züpke" <alexander.zuepke@hs-rm.de>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Patch Tracking" <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 0/2] Implement YIELD to yield in ARM and Thumb translators
Date: Fri, 26 Jun 2015 16:25:47 +0200	[thread overview]
Message-ID: <558D60EB.9080602@redhat.com> (raw)
In-Reply-To: <CAFEAcA_W=hUrxgxqGNemsHPkW_h8a5bMVZW0FbcCmgbmUe1hyA@mail.gmail.com>



On 26/06/2015 16:04, Peter Maydell wrote:
> Ping?

Oh, YIELD was what I was thinking of in the thread about IPIs, not WFE
(which would require SEV on the other core)...

The patches look good, but I cannot really say much about this code.

Paolo

> thanks
> -- PMM
> 
> On 15 June 2015 at 19:49, Peter Maydell <peter.maydell@linaro.org> wrote:
>> This patchset makes the ARM and Thumb encodings of the YIELD hint
>> instruction in the ARM cause the TCG CPU to yield control back
>> to the top level loop. This brings them into line with the A64
>> encoding which already did this.
>>
>> Patch 1 splits out DISAS_YIELD from DISAS_WFE, because although
>> we currently implement them both the same way they're semantically
>> different, and in future we might well make WFE do something
>> else. (In particular when I was reviewing Greg's patches that
>> proposed enabling trap-to-EL2-on-WFE I didn't notice that we
>> would also have ended up trapping on YIELD !)
>>
>>
>> Peter Maydell (2):
>>   target-arm: Split DISAS_YIELD from DISAS_WFE
>>   target-arm: Implement YIELD insn to yield in ARM and Thumb translators
>>
>>  target-arm/helper.h        |  1 +
>>  target-arm/op_helper.c     | 12 ++++++++++++
>>  target-arm/translate-a64.c |  6 ++++++
>>  target-arm/translate.c     |  7 +++++++
>>  target-arm/translate.h     |  1 +
>>  5 files changed, 27 insertions(+)
> 
> 

  reply	other threads:[~2015-06-26 14:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-15 18:49 [Qemu-devel] [PATCH 0/2] Implement YIELD to yield in ARM and Thumb translators Peter Maydell
2015-06-15 18:49 ` [Qemu-devel] [PATCH 1/2] target-arm: Split DISAS_YIELD from DISAS_WFE Peter Maydell
2015-06-26 16:48   ` Andreas Färber
2015-06-27  2:25   ` Peter Crosthwaite
2015-06-28 21:53     ` Peter Maydell
2015-06-15 18:49 ` [Qemu-devel] [PATCH 2/2] target-arm: Implement YIELD insn to yield in ARM and Thumb translators Peter Maydell
2015-06-26 14:04 ` [Qemu-devel] [PATCH 0/2] Implement YIELD " Peter Maydell
2015-06-26 14:25   ` Paolo Bonzini [this message]
2015-06-26 14:28     ` Peter Maydell
2015-06-26 18:16       ` Peter Crosthwaite
2015-06-26 14:35   ` Alex Züpke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558D60EB.9080602@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=alexander.zuepke@hs-rm.de \
    --cc=patches@linaro.org \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).