From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49401) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8UZm-00031Q-Sd for qemu-devel@nongnu.org; Fri, 26 Jun 2015 10:25:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z8UZj-00069w-33 for qemu-devel@nongnu.org; Fri, 26 Jun 2015 10:25:54 -0400 Received: from mail-wi0-x22a.google.com ([2a00:1450:400c:c05::22a]:38253) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8UZi-00069P-Ok for qemu-devel@nongnu.org; Fri, 26 Jun 2015 10:25:51 -0400 Received: by wibdq8 with SMTP id dq8so19455187wib.1 for ; Fri, 26 Jun 2015 07:25:50 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <558D60EB.9080602@redhat.com> Date: Fri, 26 Jun 2015 16:25:47 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1434394190-13837-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] Implement YIELD to yield in ARM and Thumb translators List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , QEMU Developers Cc: Peter Crosthwaite , =?UTF-8?B?QWxleCBa?= =?UTF-8?B?w7xwa2U=?= , =?UTF-8?B?QWxleCBCZW5uw6ll?= , Patch Tracking On 26/06/2015 16:04, Peter Maydell wrote: > Ping? Oh, YIELD was what I was thinking of in the thread about IPIs, not WFE (which would require SEV on the other core)... The patches look good, but I cannot really say much about this code. Paolo > thanks > -- PMM > > On 15 June 2015 at 19:49, Peter Maydell wrote: >> This patchset makes the ARM and Thumb encodings of the YIELD hint >> instruction in the ARM cause the TCG CPU to yield control back >> to the top level loop. This brings them into line with the A64 >> encoding which already did this. >> >> Patch 1 splits out DISAS_YIELD from DISAS_WFE, because although >> we currently implement them both the same way they're semantically >> different, and in future we might well make WFE do something >> else. (In particular when I was reviewing Greg's patches that >> proposed enabling trap-to-EL2-on-WFE I didn't notice that we >> would also have ended up trapping on YIELD !) >> >> >> Peter Maydell (2): >> target-arm: Split DISAS_YIELD from DISAS_WFE >> target-arm: Implement YIELD insn to yield in ARM and Thumb translators >> >> target-arm/helper.h | 1 + >> target-arm/op_helper.c | 12 ++++++++++++ >> target-arm/translate-a64.c | 6 ++++++ >> target-arm/translate.c | 7 +++++++ >> target-arm/translate.h | 1 + >> 5 files changed, 27 insertions(+) > >