From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37310) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8VFF-0002cw-LU for qemu-devel@nongnu.org; Fri, 26 Jun 2015 11:08:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z8VFC-00041c-Dx for qemu-devel@nongnu.org; Fri, 26 Jun 2015 11:08:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40160) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8VFC-00041O-2K for qemu-devel@nongnu.org; Fri, 26 Jun 2015 11:08:42 -0400 References: <1435330053-18733-1-git-send-email-fred.konrad@greensocs.com> <1435330053-18733-8-git-send-email-fred.konrad@greensocs.com> <558D6800.30306@siemens.com> From: Paolo Bonzini Message-ID: <558D6AF3.20707@redhat.com> Date: Fri, 26 Jun 2015 17:08:35 +0200 MIME-Version: 1.0 In-Reply-To: <558D6800.30306@siemens.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH V6 07/18] Drop global lock during TCG code execution List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka , fred.konrad@greensocs.com, qemu-devel@nongnu.org, mttcg@greensocs.com Cc: peter.maydell@linaro.org, a.spyridakis@virtualopensystems.com, mark.burton@greensocs.com, agraf@suse.de, alistair.francis@xilinx.com, guillaume.delbergue@greensocs.com, alex.bennee@linaro.org On 26/06/2015 16:56, Jan Kiszka wrote: >> > + /* >> > + * Some device's reset needs to grab the global_mutex. So just release it >> > + * here. > That's a property newly introduced by the patch, or how does this > happen? In turn, are all reset handlers now fine to be called outside of > BQL? This looks suspicious, but it's been quite a while since I last > starred at this. Yes, this looks weird... I guess this goes with the "RFC" part of the patch. Paolo