From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8VZN-0004pe-Eb for qemu-devel@nongnu.org; Fri, 26 Jun 2015 11:29:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z8VZI-0006pd-5f for qemu-devel@nongnu.org; Fri, 26 Jun 2015 11:29:33 -0400 Received: from greensocs.com ([193.104.36.180]:50803) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8VZH-0006pR-V1 for qemu-devel@nongnu.org; Fri, 26 Jun 2015 11:29:28 -0400 Message-ID: <558D6FD3.6000202@greensocs.com> Date: Fri, 26 Jun 2015 17:29:23 +0200 From: Frederic Konrad MIME-Version: 1.0 References: <1435330053-18733-1-git-send-email-fred.konrad@greensocs.com> <1435330053-18733-4-git-send-email-fred.konrad@greensocs.com> <558D676A.70801@redhat.com> In-Reply-To: <558D676A.70801@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH V6 03/18] remove unused spinlock. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org, mttcg@greensocs.com Cc: peter.maydell@linaro.org, a.spyridakis@virtualopensystems.com, mark.burton@greensocs.com, agraf@suse.de, alistair.francis@xilinx.com, guillaume.delbergue@greensocs.com, alex.bennee@linaro.org On 26/06/2015 16:53, Paolo Bonzini wrote: > > On 26/06/2015 16:47, fred.konrad@greensocs.com wrote: >> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl >> index 7f0aae9..d1e482a 100755 >> --- a/scripts/checkpatch.pl >> +++ b/scripts/checkpatch.pl >> @@ -2664,11 +2664,6 @@ sub process { >> WARN("Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr); >> } >> >> -# SPIN_LOCK_UNLOCKED & RW_LOCK_UNLOCKED are deprecated >> - if ($line =~ /\b(SPIN_LOCK_UNLOCKED|RW_LOCK_UNLOCKED)/) { >> - ERROR("Use of $1 is deprecated: see Documentation/spinlocks.txt\n" . $herecurr); >> - } >> - >> # warn about #if 0 >> if ($line =~ /^.\s*\#\s*if\s+0\b/) { >> CHK("if this code is redundant consider removing it\n" . >> @@ -2717,8 +2712,8 @@ sub process { >> ERROR("exactly one space required after that #$1\n" . $herecurr); >> } >> >> -# check for spinlock_t definitions without a comment. >> - if ($line =~ /^.\s*(struct\s+mutex|spinlock_t)\s+\S+;/ || >> +# check for mutex definitions without a comment. >> + if ($line =~ /^.\s*(struct\s+mutex)\s+\S+;/ || >> $line =~ /^.\s*(DEFINE_MUTEX)\s*\(/) { >> my $which = $1; >> if (!ctx_has_comment($first_line, $linenr)) { > The checkpatch.pl parts simply come from Linux. They don't matter for > QEMU, but we're limiting the changes to the minimum in this script. > > Paolo Ok so I can drop this part from the patch? Thanks, Fred