From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8Vx1-0001Vt-AY for qemu-devel@nongnu.org; Fri, 26 Jun 2015 11:54:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z8Vwx-0004Ai-Ul for qemu-devel@nongnu.org; Fri, 26 Jun 2015 11:53:59 -0400 Received: from cantor2.suse.de ([195.135.220.15]:36965 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8Vwx-0004AH-Ol for qemu-devel@nongnu.org; Fri, 26 Jun 2015 11:53:55 -0400 Message-ID: <558D7592.6000607@suse.de> Date: Fri, 26 Jun 2015 17:53:54 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1435330185-23248-1-git-send-email-marcandre.lureau@gmail.com> <1435330185-23248-40-git-send-email-marcandre.lureau@gmail.com> <558D6AF2.2080606@suse.de> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 39/39] tests: Add ivshmem qtest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Cc: cam , QEMU , stefanha@redhat.com, Alexander Graf Hi, Please don't use HTML mails, that breaks quoting as you can see below. Am 26.06.2015 um 17:27 schrieb Marc-Andr=C3=A9 Lureau: > On Fri, Jun 26, 2015 at 5:08 PM, Andreas F=C3=A4rber > wrote: >=20 >=20 > For the second time within days you're posting a patch for somethin= g > that's been on the list already... The commit message above is enti= rely >=20 >=20 > Sorry which patch are you refering to? This one vs. my http://patchwork.ozlabs.org/patch/336367/ And my "[PATCH for-2.3? 0/7] tests: Fix TCG make test" series vs. your http://patchwork.ozlabs.org/patch/487719/ > Is it wrong to repost a old patch and adding, while adding signoff and > modifications? > (what I just did in this series for David patches) "contrib: add ivshmem client and server" looks (formally) okay except for the final [...], which should go before your Signed-off-by. That's not what you've done here though, as I complained. You did not ask me about the state of my patch either before you posted this. >=20 > empty, and at least this patch is not carrying any form of change l= og > either. You seem to add more tests than I did at the time, but that > still does not warrant dropping previous authorship info (Signed-of= f-by, > From, copyright). >=20 >=20 > Sorry, I will try to describe the tests in the commit log (I thought > they where already > self-explanatory, but commit comments is always nice anyway) >=20 > Tbh, your patch was just launching one instance of qemu with ivshmem. I= f you > look at the one I proposed, you'll notice that it is completely > different: I don't think your > signoff or copyright should be added here. Well, I disagree. Extending a test case does not give you the right to replace SUSE with Red Hat. Makes it look like an NIH problem. Also, see the discussion on my RFC: CONFIG_LINUX is wrong here. It would need to depend on KVM/eventfd, and for that there is no easy config option available here, which stopped my patch at the time. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; = HRB 21284 (AG N=C3=BCrnberg)