From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8WNS-0006Wk-JP for qemu-devel@nongnu.org; Fri, 26 Jun 2015 12:21:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z8WNP-000594-Sg for qemu-devel@nongnu.org; Fri, 26 Jun 2015 12:21:18 -0400 Received: from mail-wi0-x22c.google.com ([2a00:1450:400c:c05::22c]:37386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8WNP-00058r-KX for qemu-devel@nongnu.org; Fri, 26 Jun 2015 12:21:15 -0400 Received: by wicgi11 with SMTP id gi11so22217992wic.0 for ; Fri, 26 Jun 2015 09:21:15 -0700 (PDT) Sender: Paolo Bonzini References: <1435330053-18733-1-git-send-email-fred.konrad@greensocs.com> <1435330053-18733-19-git-send-email-fred.konrad@greensocs.com> From: Paolo Bonzini Message-ID: <558D7BF9.70601@redhat.com> Date: Fri, 26 Jun 2015 18:21:13 +0200 MIME-Version: 1.0 In-Reply-To: <1435330053-18733-19-git-send-email-fred.konrad@greensocs.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH V6 18/18] translate-all: (wip) use tb_flush_safe when we can't alloc more tb. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: fred.konrad@greensocs.com, qemu-devel@nongnu.org, mttcg@listserver.greensocs.com Cc: peter.maydell@linaro.org, a.spyridakis@virtualopensystems.com, mark.burton@greensocs.com, agraf@suse.de, alistair.francis@xilinx.com, guillaume.delbergue@greensocs.com, alex.bennee@linaro.org On 26/06/2015 16:47, fred.konrad@greensocs.com wrote: > @@ -1147,7 +1147,7 @@ TranslationBlock *tb_gen_code(CPUState *cpu, > tb = tb_alloc(pc); > if (!tb) { > /* flush must be done */ > - tb_flush(env); > + tb_flush_safe(env); Should you just call cpu_loop_exit() here, instead of redoing the tb_alloc etc.? Paolo > /* cannot fail at this point */ > tb = tb_alloc(pc);