From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43897)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1Z8WeR-0005S0-QR
	for qemu-devel@nongnu.org; Fri, 26 Jun 2015 12:38:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1Z8WeM-0005Yy-Rh
	for qemu-devel@nongnu.org; Fri, 26 Jun 2015 12:38:51 -0400
Received: from greensocs.com ([193.104.36.180]:36849)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1Z8WeM-0005Yu-L1
	for qemu-devel@nongnu.org; Fri, 26 Jun 2015 12:38:46 -0400
Message-ID: <558D8013.60809@greensocs.com>
Date: Fri, 26 Jun 2015 18:38:43 +0200
From: Frederic Konrad <fred.konrad@greensocs.com>
MIME-Version: 1.0
References: <1435330053-18733-1-git-send-email-fred.konrad@greensocs.com>
	<1435330053-18733-19-git-send-email-fred.konrad@greensocs.com>
	<558D7BF9.70601@redhat.com>
In-Reply-To: <558D7BF9.70601@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH V6 18/18] translate-all: (wip) use
 tb_flush_safe when we can't alloc more tb.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, mttcg@listserver.greensocs.com
Cc: peter.maydell@linaro.org, a.spyridakis@virtualopensystems.com, mark.burton@greensocs.com, agraf@suse.de, alistair.francis@xilinx.com, guillaume.delbergue@greensocs.com, alex.bennee@linaro.org

On 26/06/2015 18:21, Paolo Bonzini wrote:
>
> On 26/06/2015 16:47, fred.konrad@greensocs.com wrote:
>> @@ -1147,7 +1147,7 @@ TranslationBlock *tb_gen_code(CPUState *cpu,
>>       tb = tb_alloc(pc);
>>       if (!tb) {
>>           /* flush must be done */
>> -        tb_flush(env);
>> +        tb_flush_safe(env);
> Should you just call cpu_loop_exit() here, instead of redoing the
> tb_alloc etc.?
>
> Paolo
Ah yes good point!

Thanks,
Fred

>>           /* cannot fail at this point */
>>           tb = tb_alloc(pc);