From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8YQs-0001Ft-9N for qemu-devel@nongnu.org; Fri, 26 Jun 2015 14:32:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z8YQr-0000IT-D6 for qemu-devel@nongnu.org; Fri, 26 Jun 2015 14:32:58 -0400 Message-ID: <558D9AD1.1060002@redhat.com> Date: Fri, 26 Jun 2015 14:32:49 -0400 From: John Snow MIME-Version: 1.0 References: <1435018875-22527-1-git-send-email-jsnow@redhat.com> <1435018875-22527-14-git-send-email-jsnow@redhat.com> <20150626155143.GE31186@stefanha-thinkpad.redhat.com> In-Reply-To: <20150626155143.GE31186@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 13/16] ahci: add get_cmd_header helper List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 06/26/2015 11:51 AM, Stefan Hajnoczi wrote: > On Mon, Jun 22, 2015 at 08:21:12PM -0400, John Snow wrote: >> +static AHCICmdHdr *get_cmd_header(AHCIState *s, uint8_t port, >> uint8_t slot) +{ + if (port > s->ports || slot > >> AHCI_MAX_CMDS) { > > Should these be >= instead of >? Otherwise 1 element beyond the > end of the array can be accessed. > Sigh. Yes, yes it should. Thank you for saving me from myself. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVjZrRAAoJEH3vgQaq/DkOjcMP/0CqxJAWcgsnFH5Opwz7iNbm OyvLakvzUmU958qN3nzG2vMME3WwyVF3bxVJkoT3v1Pc6Tm9e+hq+R1oDzD0TD6X tfjQTc5JZcViKSD74Huo85gKoVp3Tp4idOaaVFn36TmP9gk5i6g/C0Nf7EzY12Er 4op6mLvBhiU6NH72UwP4HHij0KZCMCVYYH4qhAWsil/QIugAgELlM9TFkVI49lHs WN3IE+5gQijd99Z5VJaC9wrmtOdZWHblfTeWMvVQfMfbg5dJ2Aiya1tHlw6QrPzb 7nGPHTwyGLmNsvUsNqMHrWGaL9e4iEwXGYNRnIT16L8QPzGqg7v4D3lvJcGv5LrM OFPje2Fk9w8OGdgRjrQhQcJXfU+IPkvlwnW7G3NO2Ts0GK5cHClRafZVjvAhMuXs 5M89BTdi7LBGJ7EWq8ByP5mxPj+hiR3hsSG41OPFg3e0VpwtgFJ6umaZde1tMrHp IwnOZcvXUoTOAna3Y4E/fSwK1jKczTXIvkl4+HnJB40ekyoSkyl6qXV1FlMRiMnq pAeJ5jgBovuV2gx8pLYU3ipR0LJTjzz7N39FkAJJyekWWjNVrZ4Ue5IGW/pXKVkN SjeSrZTtxSmyO8BPya7/xsqjiqo3v7m2jSBLTVEsUtkFEaet4xlAH2OQZBvlTbuI n5Hc61NkB6qMU5k6We31 =Sfdd -----END PGP SIGNATURE-----