From: Ilya Leoshkevich <iii@linux.ibm.com>
To: David Hildenbrand <david@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Thomas Huth <thuth@redhat.com>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [PATCH 1/2] target/s390x: Use a 16-bit immediate in VREP
Date: Mon, 07 Aug 2023 19:02:41 +0200 [thread overview]
Message-ID: <558af8b33fa9164b0a5a21f61aa583a3776784f7.camel@linux.ibm.com> (raw)
In-Reply-To: <baa436ac-ffe4-8c7d-6eee-af9c26fe3c0f@redhat.com>
On Mon, 2023-08-07 at 19:00 +0200, David Hildenbrand wrote:
> On 07.08.23 18:34, Ilya Leoshkevich wrote:
> > Unlike most other instructions that contain an immediate element
> > index,
> > VREP's one is 16-bit, and not 4-bit. The code uses only 8 bits, so
> > using, e.g., 0x101 does not lead to a specification exception.
> >
> > Fix by checking all 16 bits.
> >
> > Cc: qemu-stable@nongnu.org
>
> Just curious, why stable? Are there valid programs that set invalid
> element size and they are fixed by this?
None that I know of, but I thought this was still nice to have, and at
the same time small enough to not cause any trouble.
> LGTM
>
> Reviewed-by: David Hildenbrand <david@redhat.com>
[...]
>
next prev parent reply other threads:[~2023-08-07 17:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 16:34 [PATCH 1/2] target/s390x: Use a 16-bit immediate in VREP Ilya Leoshkevich
2023-08-07 16:34 ` [PATCH 2/2] tests/tcg/s390x: Test VREP Ilya Leoshkevich
2023-08-07 17:00 ` [PATCH 1/2] target/s390x: Use a 16-bit immediate in VREP David Hildenbrand
2023-08-07 17:02 ` Ilya Leoshkevich [this message]
2023-08-07 17:04 ` David Hildenbrand
2023-08-07 17:27 ` Michael Tokarev
2023-08-08 10:01 ` Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558af8b33fa9164b0a5a21f61aa583a3776784f7.camel@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).