From: Ilya Leoshkevich <iii@linux.ibm.com>
To: David Hildenbrand <david@redhat.com>,
Laurent Vivier <laurent@vivier.eu>,
Richard Henderson <richard.henderson@linaro.org>,
Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
Claudio Fontana <cfontana@suse.de>,
qemu-stable@nongnu.org
Subject: Re: [PATCH 2/3] target/s390x: Fix the "ignored match" case in VSTRS
Date: Mon, 07 Aug 2023 10:10:28 +0200 [thread overview]
Message-ID: <558f087ae3f7e13a202f1e7ddda22e5996066269.camel@linux.ibm.com> (raw)
In-Reply-To: <5ea25092-b362-0587-5ad0-f3883cc86ba1@redhat.com>
On Sat, 2023-08-05 at 10:02 +0200, David Hildenbrand wrote:
> On 05.08.23 01:03, Ilya Leoshkevich wrote:
> > Currently the emulation of VSTRS recognizes partial matches in
> > presence
> > of \0 in the haystack, which, according to PoP, is not correct:
> >
> > If the ZS flag is one and a zero byte was detected
> > in the second operand, then there can not be a
> > partial match ...
> >
> > Add a check for this. While at it, fold a number of explicitly
> > handled
> > special cases into the generic logic.
>
> Can we split that off? Or doesn't it make sense to split it off after
> fixing the issue?
I could do this if this is important, e.g., for stable, but I came to
the conclusion that I needed to get rid of the special cases after I
had to add the new check to more than one place.
next prev parent reply other threads:[~2023-08-07 8:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 23:03 [PATCH 0/3] target/s390x: Fix the "ignored match" case in VSTRS Ilya Leoshkevich
2023-08-04 23:03 ` [PATCH 1/3] linux-user/elfload: Enable vxe2 on s390x Ilya Leoshkevich
2023-08-05 4:22 ` Richard Henderson
2023-08-05 8:01 ` David Hildenbrand
2023-08-17 9:17 ` Claudio Fontana
2023-08-04 23:03 ` [PATCH 2/3] target/s390x: Fix the "ignored match" case in VSTRS Ilya Leoshkevich
2023-08-05 8:02 ` David Hildenbrand
2023-08-07 8:10 ` Ilya Leoshkevich [this message]
2023-08-23 10:03 ` David Hildenbrand
2023-08-06 12:54 ` Claudio Fontana
2023-08-04 23:03 ` [PATCH 3/3] tests/tcg/s390x: Test VSTRS Ilya Leoshkevich
2023-08-06 11:05 ` Claudio Fontana
2023-08-07 8:08 ` Ilya Leoshkevich
2023-08-07 8:45 ` Claudio Fontana
2023-08-17 9:37 ` Claudio Fontana
2023-08-17 16:57 ` Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558f087ae3f7e13a202f1e7ddda22e5996066269.camel@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=cfontana@suse.de \
--cc=david@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).