From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36153)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Z9VN5-0007oh-0k
	for qemu-devel@nongnu.org; Mon, 29 Jun 2015 05:28:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Z9VMz-0005xY-Jl
	for qemu-devel@nongnu.org; Mon, 29 Jun 2015 05:28:58 -0400
Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:38669)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Z9VMz-0005xE-Ca
	for qemu-devel@nongnu.org; Mon, 29 Jun 2015 05:28:53 -0400
Received: by wibdq8 with SMTP id dq8so66417831wib.1
	for <qemu-devel@nongnu.org>; Mon, 29 Jun 2015 02:28:52 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1435259818-6864-1-git-send-email-aurelien@aurel32.net>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <55910FCB.30900@twiddle.net>
Date: Mon, 29 Jun 2015 10:28:43 +0100
MIME-Version: 1.0
In-Reply-To: <1435259818-6864-1-git-send-email-aurelien@aurel32.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] target-s390x: fix CONVERT TO BINARY (CVD,
	CVDY)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>, qemu-devel@nongnu.org
Cc: Alexander Graf <agraf@suse.de>

On 06/25/2015 08:16 PM, Aurelien Jarno wrote:
>       for (shift = 4; (shift < 64) && bin; shift += 4) {
> -        int current_number = bin % 10;
> -
> -        dec |= (current_number) << shift;
> +        dec |= (bin % 10) << shift;
>           bin /= 10;
>       }

You've changed from 32-bit division to 64-bit division just to solve a problem 
with the shift.  Better to just change the type of current_number there.


r~