From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9Vgv-00026I-M3 for qemu-devel@nongnu.org; Mon, 29 Jun 2015 05:49:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9Vgq-0000Id-IV for qemu-devel@nongnu.org; Mon, 29 Jun 2015 05:49:29 -0400 Received: from mail-wg0-f52.google.com ([74.125.82.52]:34774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9Vgq-0000Ht-Ce for qemu-devel@nongnu.org; Mon, 29 Jun 2015 05:49:24 -0400 Received: by wgqq4 with SMTP id q4so136507267wgq.1 for ; Mon, 29 Jun 2015 02:49:22 -0700 (PDT) Message-ID: <5591148F.7090109@linaro.org> Date: Mon, 29 Jun 2015 11:49:03 +0200 From: Eric Auger MIME-Version: 1.0 References: <1435339767-2301-1-git-send-email-eric.auger@linaro.org> <1435339767-2301-6-git-send-email-eric.auger@linaro.org> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v18 5/6] kvm: some fixes to kvm_resamplefds_allowed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Peter Crosthwaite , eric.auger@st.com, Patch Tracking , QEMU Developers , Alex Williamson , Paolo Bonzini , Christoffer Dall On 06/29/2015 11:47 AM, Peter Maydell wrote: > On 26 June 2015 at 18:29, Eric Auger wrote: >> Commit f41389ae3c54b introduced kvm_resamplefds_enabled() and >> associated kvm_resamplefds_allowed boolean. This patch adds >> non-KVM version for kvm_resamplefds_enabled and also declares >> kvm_resamplefds_allowed in kvm-stub as it is done for fellow >> kvm_irqfds_allowed. >> >> Signed-off-by: Eric Auger >> --- >> include/sysemu/kvm.h | 1 + >> kvm-stub.c | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h >> index ba612fc..983e99e 100644 >> --- a/include/sysemu/kvm.h >> +++ b/include/sysemu/kvm.h >> @@ -152,6 +152,7 @@ extern bool kvm_readonly_mem_allowed; >> #define kvm_halt_in_kernel() (false) >> #define kvm_eventfds_enabled() (false) >> #define kvm_irqfds_enabled() (false) >> +#define kvm_resamplefds_enabled() (false) >> #define kvm_msi_via_irqfd_enabled() (false) >> #define kvm_gsi_routing_allowed() (false) >> #define kvm_gsi_direct_mapping() (false) >> diff --git a/kvm-stub.c b/kvm-stub.c >> index 977de21..d9ad624 100644 >> --- a/kvm-stub.c >> +++ b/kvm-stub.c >> @@ -24,6 +24,7 @@ bool kvm_kernel_irqchip; >> bool kvm_async_interrupts_allowed; >> bool kvm_eventfds_allowed; >> bool kvm_irqfds_allowed; >> +bool kvm_resamplefds_allowed; >> bool kvm_msi_via_irqfd_allowed; >> bool kvm_gsi_routing_allowed; >> bool kvm_gsi_direct_mapping; >> -- >> 1.8.3.2 > > Reviewed-by: Peter Maydell > > though "kvm: implement kvm_resamplefds_enabled() for !CONFIG_KVM" > might be a more informative subject line if you need to respin > for some other reason. OK. Thanks for the whole review Best Regards Eric > > thanks > -- PMM >