From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9VjA-0003zj-B8 for qemu-devel@nongnu.org; Mon, 29 Jun 2015 05:51:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9Vj5-0001xu-Tt for qemu-devel@nongnu.org; Mon, 29 Jun 2015 05:51:48 -0400 Message-ID: <5591152B.7090200@redhat.com> Date: Mon, 29 Jun 2015 11:51:39 +0200 From: Laurent Vivier MIME-Version: 1.0 References: <1435556214-2916-1-git-send-email-david@gibson.dropbear.id.au> <1435556214-2916-5-git-send-email-david@gibson.dropbear.id.au> <5590F958.9020306@redhat.com> <20150629113037.64f0d08f@thh440s> In-Reply-To: <20150629113037.64f0d08f@thh440s> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] Disable "info irq" and "info pic" for target-ppc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: agraf@suse.de, qemu-devel@nongnu.org, armbru@redhat.com, qemu-ppc@nongnu.org, lcapitulino@redhat.com, afaerber@suse.de, David Gibson On 29/06/2015 11:30, Thomas Huth wrote: > On Mon, 29 Jun 2015 09:52:56 +0200 > Laurent Vivier wrote: > >> >> >> On 29/06/2015 07:36, David Gibson wrote: >>> The "info irq" and "info pic" HMP commands are available on some, but not >>> all targets, and what they do isn't terribly consistent. For SPARC and >>> LM32 they do something platform specific, but for x86, powerpc, and MIPS >>> they print some information from the i8259 (and only the i8259) interrupt >>> controller. >>> >>> It's debatable whether these commands are any use at all, and we should >>> probably make better, qdev aware ways of getting information from a >>> machines PICs. However, those don't exist yet, so on x86 it's at least >>> potentially useful to have these HMP commands. I can't speak for MIPS. >>> >>> For ppc, though, the i8259, if it exists at all, is usually just a >>> secondary controller for legacy ISA. The only case where i8259 is the >>> main system PIC on ppc is for the ancient and little-used PReP platform. >>> >>> So, even without QOM-ish replacement, the info pic and info irq HMP >>> commands have no value on ppc. >>> >>> This patch, therefore, disables these commands for ppc targets. This will >>> allow ppc builds which don't include PReP to not include ISA bus support >>> either. >>> >>> Signed-off-by: David Gibson >>> --- >>> monitor.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/monitor.c b/monitor.c >>> index aeea2b5..8c56bfa 100644 >>> --- a/monitor.c >>> +++ b/monitor.c >>> @@ -2573,7 +2573,7 @@ static mon_cmd_t info_cmds[] = { >>> .help = "show the command line history", >>> .mhandler.cmd = hmp_info_history, >>> }, >>> -#if defined(TARGET_I386) || defined(TARGET_PPC) || defined(TARGET_MIPS) || \ >>> +#if defined(TARGET_I386) || defined(TARGET_MIPS) || \ >>> defined(TARGET_LM32) || (defined(TARGET_SPARC) && !defined(TARGET_SPARC64)) >>> { >>> .name = "irq", >>> >> >> Perhaps we can a use a "#if defined(CONFIG_I8259) || >> defined(CONFIG_LM32) || (defined(TARGE_SPARC) && >> !defined(TARGET_SPARC64))" instead, so we keep the command for PReP ? > > AFAIK this currently won't work since CONFIG_I8259 is only defined for > the Makefiles, but not for the C pre-processor :-( Yes, I see that afterward, but ... > So unless somebody fixes that first, I think David's approach is the > only practicable solution right now. if you add "config-devices.h" in GENERATED_HEADERS in Makefile.target, and include "config-devices.h" in monitor.c, it works (all PREP dependencies in default-configs/ppc64-softmmu.mak must be removed too) But does this change acceptable for a tiny improvement ? Laurent