From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9Vxm-0006B9-Md for qemu-devel@nongnu.org; Mon, 29 Jun 2015 06:06:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9Vxi-0000km-MK for qemu-devel@nongnu.org; Mon, 29 Jun 2015 06:06:54 -0400 Message-ID: <559118B5.4060306@suse.de> Date: Mon, 29 Jun 2015 12:06:45 +0200 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1435556214-2916-1-git-send-email-david@gibson.dropbear.id.au> <1435556214-2916-5-git-send-email-david@gibson.dropbear.id.au> <5590F958.9020306@redhat.com> <20150629113037.64f0d08f@thh440s> <5591152B.7090200@redhat.com> <559115FC.3090805@redhat.com> In-Reply-To: <559115FC.3090805@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 4/4] Disable "info irq" and "info pic" for target-ppc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: agraf@suse.de, Thomas Huth , qemu-devel@nongnu.org, armbru@redhat.com, qemu-ppc@nongnu.org, lcapitulino@redhat.com, David Gibson Am 29.06.2015 um 11:55 schrieb Laurent Vivier: > On 29/06/2015 11:51, Laurent Vivier wrote: >> On 29/06/2015 11:30, Thomas Huth wrote: >>> On Mon, 29 Jun 2015 09:52:56 +0200 >>> Laurent Vivier wrote: >>>> On 29/06/2015 07:36, David Gibson wrote: >>>>> diff --git a/monitor.c b/monitor.c >>>>> index aeea2b5..8c56bfa 100644 >>>>> --- a/monitor.c >>>>> +++ b/monitor.c >>>>> @@ -2573,7 +2573,7 @@ static mon_cmd_t info_cmds[] =3D { >>>>> .help =3D "show the command line history", >>>>> .mhandler.cmd =3D hmp_info_history, >>>>> }, >>>>> -#if defined(TARGET_I386) || defined(TARGET_PPC) || defined(TARGET_= MIPS) || \ >>>>> +#if defined(TARGET_I386) || defined(TARGET_MIPS) || \ >>>>> defined(TARGET_LM32) || (defined(TARGET_SPARC) && !defined(TAR= GET_SPARC64)) >>>>> { >>>>> .name =3D "irq", >>>>> >>>> >>>> Perhaps we can a use a "#if defined(CONFIG_I8259) || >>>> defined(CONFIG_LM32) || (defined(TARGE_SPARC) && >>>> !defined(TARGET_SPARC64))" instead, so we keep the command for PReP = ? >>> >>> AFAIK this currently won't work since CONFIG_I8259 is only defined fo= r >>> the Makefiles, but not for the C pre-processor :-( >> >> Yes, I see that afterward, but ... >> >>> So unless somebody fixes that first, I think David's approach is the >>> only practicable solution right now. >> >> if you add "config-devices.h" in GENERATED_HEADERS in Makefile.target, >> and include "config-devices.h" in monitor.c, it works (all PREP >> dependencies in default-configs/ppc64-softmmu.mak must be removed too) >> >> But does this change acceptable for a tiny improvement ? >=20 > In fine, I think we can also do like for sparc: >=20 > defined(TARGET_PPC) && !defined(TARGET_PPC64) Alex specifically requested PReP to be made available in ppc64, too. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)