From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9W2o-0007ik-ED for qemu-devel@nongnu.org; Mon, 29 Jun 2015 06:12:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9W2l-00036U-9E for qemu-devel@nongnu.org; Mon, 29 Jun 2015 06:12:06 -0400 Message-ID: <559119F1.2020507@suse.de> Date: Mon, 29 Jun 2015 12:12:01 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1435556214-2916-1-git-send-email-david@gibson.dropbear.id.au> <1435556214-2916-2-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1435556214-2916-2-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/4] Split serial-isa into its own config option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , Anthony Green Cc: lvivier@redhat.com, agraf@suse.de, thuth@redhat.com, Peter Maydell , armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, qemu-ppc@nongnu.org Am 29.06.2015 um 07:36 schrieb David Gibson: > At present, the core device model code for 8250-like serial ports > (serial.c) and the code for serial ports attached to ISA-style legacy I= O > (serial-isa.c) are both controlled by the CONFIG_SERIAL variable. >=20 > There are lots and lots of embedded platforms that have 8250-like seria= l > ports but have never had anything resembling ISA legacy IO. Therefore, > split serial-isa into its own CONFIG_SERIAL_ISA option so it can be > disabled for platforms where it's not appropriate. >=20 > For now, I enabled CONFIG_SERIAL_ISA in every default-config where > CONFIG_SERIAL is enabled, excepting microblaze, xtensa and or32. Those > platforms have technically lost functionality, but since they have no > other PCI or ISA devices, it's fairly clear they never actually used > leagacy IO stuff. I think we can add moxie to that list, I'd be very surprised if it uses ISA. Applies also to 2/4. CC'ing the maintainer. Which arm machines use ISA? Regards, Andreas >=20 > Signed-off-by: David Gibson > --- > default-configs/alpha-softmmu.mak | 1 + > default-configs/arm-softmmu.mak | 1 + > default-configs/i386-softmmu.mak | 1 + > default-configs/mips-softmmu.mak | 1 + > default-configs/mips64-softmmu.mak | 1 + > default-configs/mips64el-softmmu.mak | 1 + > default-configs/mipsel-softmmu.mak | 1 + > default-configs/moxie-softmmu.mak | 1 + > default-configs/ppc-softmmu.mak | 1 + > default-configs/ppc64-softmmu.mak | 1 + > default-configs/ppcemb-softmmu.mak | 1 + > default-configs/sh4-softmmu.mak | 1 + > default-configs/sh4eb-softmmu.mak | 1 + > default-configs/sparc64-softmmu.mak | 1 + > default-configs/x86_64-softmmu.mak | 1 + > hw/char/Makefile.objs | 3 ++- > 16 files changed, 17 insertions(+), 1 deletion(-) [snip] --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)