From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59734) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9WDc-00046E-Ml for qemu-devel@nongnu.org; Mon, 29 Jun 2015 06:23:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9WDZ-0001jE-Ft for qemu-devel@nongnu.org; Mon, 29 Jun 2015 06:23:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41581) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9WDZ-0001j1-97 for qemu-devel@nongnu.org; Mon, 29 Jun 2015 06:23:13 -0400 Message-ID: <55911C89.30706@redhat.com> Date: Mon, 29 Jun 2015 12:23:05 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <1435571659-29186-1-git-send-email-mst@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] MAINTAINERS: fix pattern for PC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , "Michael S. Tsirkin" Cc: Kevin Wolf , QEMU Developers , Markus Armbruster , Stefan Hajnoczi , Amit Shah , Paolo Bonzini On 06/29/15 12:00, Peter Maydell wrote: > On 29 June 2015 at 10:54, Michael S. Tsirkin wrote: >> Looks like hw/i386/ does not work, hw/i386/* >> seems to work better. > > This is kind of vague... The documentation at the top > of MAINTAINERS says the difference is that "hw/i386/" > means "all files in and below hw/i386/", whereas > "hw/i386/*" means "all files in hw/i386, but not below" > (so won't match anything in hw/i386/kvm/ or hw/i386/xen/). > Is this the effect you're trying to achieve? It would > be nice to mention the symptoms of the problem this patch > is fixing in the commit message... Assume I format the patch series: http://lists.nongnu.org/archive/html/qemu-devel/2015-06/msg06677.html into a single file, with git format-patch --notes --cover-letter --numbered --stdout and then run scripts/get_maintainer.pl on the resultant patch series file. Before this patch, I get: Paolo Bonzini (maintainer:X86) Richard Henderson (maintainer:X86) Eduardo Habkost (maintainer:X86) "Michael S. Tsirkin" (supporter:PC) Since Michael was listed at the bottom of that list, I didn't CC him. (I wanted to give him a breather after my many PXB iterations.) Turns out that wasn't a good choice. With this patch for MAINTAINERS in place, the script reports Michael at the top: "Michael S. Tsirkin" (supporter:PC) Paolo Bonzini (maintainer:X86) Richard Henderson (maintainer:X86) Eduardo Habkost (maintainer:X86) Maybe I should have considered something else than just the ordering of the names in the list, not sure... Hm, yes, this is at least partly (if not fully) my fault. MAINTAINERS says S: Status, one of the following: Supported: Someone is actually paid to look after this. Maintained: Someone actually looks after it. I didn't realize this distinction, and I also didn't realize that "supporter" and "maintainer" were derived directly from "Supported" and "Maintained". It would be helpful if developers with more jurisdiction (according to the Supported / Maintained / Odd Fixes classification) were listed higher in the output. Thanks Laszlo > >> Reported-by: Laszlo Ersek >> Signed-off-by: Michael S. Tsirkin >> --- >> MAINTAINERS | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 3d48a6b..39a01ab 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -578,7 +578,7 @@ PC >> M: Michael S. Tsirkin >> S: Supported >> F: include/hw/i386/ >> -F: hw/i386/ >> +F: hw/i386/* >> F: hw/pci-host/piix.c >> F: hw/pci-host/q35.c >> F: hw/pci-host/pam.c > > thanks > -- PMM >