From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33635) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9WHF-0006Yd-CC for qemu-devel@nongnu.org; Mon, 29 Jun 2015 06:27:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9WHA-0003vW-6m for qemu-devel@nongnu.org; Mon, 29 Jun 2015 06:27:01 -0400 Message-ID: <55911D6A.7000800@suse.de> Date: Mon, 29 Jun 2015 12:26:50 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1435556214-2916-1-git-send-email-david@gibson.dropbear.id.au> <1435556214-2916-3-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1435556214-2916-3-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/4] Allow ISA bus to be configured out List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: lvivier@redhat.com, agraf@suse.de, thuth@redhat.com, armbru@redhat.com, Anthony Green , qemu-devel@nongnu.org, lcapitulino@redhat.com, qemu-ppc@nongnu.org, Paolo Bonzini , Guan Xuetao Am 29.06.2015 um 07:36 schrieb David Gibson: > Currently, the code to handle the legacy ISA bus is always included in > qemu. However there are lots of platforms that don't include ISA legac= y > devies, and quite a few that have never used ISA legacy devices at all. >=20 > This patch allows the ISA bus code to be disabled in the configuration = for > platforms where it doesn't make sense. For now, the default configs ar= e > adjusted to include ISA on all platforms including PCI (since > CONFIG_IDE_CORE which is in pci.mak requires ISA support) and also seve= ral > others which include ISA devices. We may want to pare this down in fut= ure. PCI also allows to have a PCI-ISA bridge such as the i82378, which means that all PCI platforms can potentially obtain an actual ISA bus. So at least the commit message could use a makeover to avoid someone touching IDE to blindly disable the dependency. You'd also need to think about the qtests then: $ git grep i82378 -- tests/ tests/endianness-test.c: { "ppc", "g3beige", 0xfe000000, .bswap =3D true, .superio =3D "i82378" }, tests/endianness-test.c: { "ppc", "bamboo", 0xe8000000, .bswap =3D true, .superio =3D "i82378" }, tests/endianness-test.c: { "ppc64", "mac99", 0xf2000000, .bswap =3D true, .superio =3D "i82378" }, tests/endianness-test.c: .bswap =3D true, .superio =3D "i82378" }, tests/endianness-test.c: { "sh4", "r2d", 0xfe240000, .superio =3D "i82378" }, tests/endianness-test.c: { "sh4eb", "r2d", 0xfe240000, .bswap =3D true= , .superio =3D "i82378" }, >=20 > This patch becomes more useful since b19c1c0 "isa: remove isa_mem_base > variable." since that removes a dependency on isa-bus.c from vga.c. >=20 > Signed-off-by: David Gibson > --- > default-configs/moxie-softmmu.mak | 1 + > default-configs/pci.mak | 1 + > default-configs/sparc-softmmu.mak | 1 + > default-configs/unicore32-softmmu.mak | 1 + > hw/isa/Makefile.objs | 2 +- > 5 files changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/default-configs/moxie-softmmu.mak b/default-configs/moxie-= softmmu.mak > index 7e22863..e00d099 100644 > --- a/default-configs/moxie-softmmu.mak > +++ b/default-configs/moxie-softmmu.mak > @@ -1,5 +1,6 @@ > # Default configuration for moxie-softmmu > =20 > +CONFIG_ISA_BUS=3Dy > CONFIG_MC146818RTC=3Dy > CONFIG_SERIAL=3Dy > CONFIG_SERIAL_ISA=3Dy I guess we can drop it for moxie ... > diff --git a/default-configs/pci.mak b/default-configs/pci.mak > index 7e10903..9f2b98c 100644 > --- a/default-configs/pci.mak > +++ b/default-configs/pci.mak > @@ -1,4 +1,5 @@ > CONFIG_PCI=3Dy > +CONFIG_ISA_BUS=3Dy > CONFIG_VIRTIO_PCI=3Dy > CONFIG_VIRTIO=3Dy > CONFIG_USB_UHCI=3Dy > diff --git a/default-configs/sparc-softmmu.mak b/default-configs/sparc-= softmmu.mak > index ab796b3..004b0f4 100644 > --- a/default-configs/sparc-softmmu.mak > +++ b/default-configs/sparc-softmmu.mak > @@ -1,5 +1,6 @@ > # Default configuration for sparc-softmmu > =20 > +CONFIG_ISA_BUS=3Dy > CONFIG_ECC=3Dy > CONFIG_ESP=3Dy > CONFIG_ESCC=3Dy > diff --git a/default-configs/unicore32-softmmu.mak b/default-configs/un= icore32-softmmu.mak > index de38577..5f6c4a8 100644 > --- a/default-configs/unicore32-softmmu.mak > +++ b/default-configs/unicore32-softmmu.mak > @@ -1,4 +1,5 @@ > # Default configuration for unicore32-softmmu > +CONFIG_ISA_BUS=3Dy > CONFIG_PUV3=3Dy > CONFIG_PTIMER=3Dy > CONFIG_PCKBD=3Dy ... and for unicore32? Regards, Andreas > diff --git a/hw/isa/Makefile.objs b/hw/isa/Makefile.objs > index 9164556..fb37c55 100644 > --- a/hw/isa/Makefile.objs > +++ b/hw/isa/Makefile.objs > @@ -1,4 +1,4 @@ > -common-obj-y +=3D isa-bus.o > +common-obj-$(CONFIG_ISA_BUS) +=3D isa-bus.o > common-obj-$(CONFIG_APM) +=3D apm.o > common-obj-$(CONFIG_I82378) +=3D i82378.o > common-obj-$(CONFIG_PC87312) +=3D pc87312.o --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)