From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38527) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9WXg-0005vB-AM for qemu-devel@nongnu.org; Mon, 29 Jun 2015 06:44:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9WXa-0004iL-GI for qemu-devel@nongnu.org; Mon, 29 Jun 2015 06:44:00 -0400 Message-ID: <55912166.6030504@suse.de> Date: Mon, 29 Jun 2015 12:43:50 +0200 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1435556214-2916-1-git-send-email-david@gibson.dropbear.id.au> <1435556214-2916-5-git-send-email-david@gibson.dropbear.id.au> <5590F958.9020306@redhat.com> <20150629113037.64f0d08f@thh440s> <5591152B.7090200@redhat.com> <559115FC.3090805@redhat.com> <559118B5.4060306@suse.de> <55911C53.9070001@redhat.com> <55911F9A.4040208@suse.de> In-Reply-To: <55911F9A.4040208@suse.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 4/4] Disable "info irq" and "info pic" for target-ppc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: agraf@suse.de, Thomas Huth , qemu-devel@nongnu.org, armbru@redhat.com, qemu-ppc@nongnu.org, lcapitulino@redhat.com, David Gibson Am 29.06.2015 um 12:36 schrieb Andreas F=E4rber: > Am 29.06.2015 um 12:22 schrieb Laurent Vivier: >> On 29/06/2015 12:06, Andreas F=E4rber wrote: >>> Am 29.06.2015 um 11:55 schrieb Laurent Vivier: >>>> On 29/06/2015 11:51, Laurent Vivier wrote: >>>>> On 29/06/2015 11:30, Thomas Huth wrote: >>>>>> On Mon, 29 Jun 2015 09:52:56 +0200 >>>>>> Laurent Vivier wrote: >>>>>>> On 29/06/2015 07:36, David Gibson wrote: >>>>>>>> diff --git a/monitor.c b/monitor.c >>>>>>>> index aeea2b5..8c56bfa 100644 >>>>>>>> --- a/monitor.c >>>>>>>> +++ b/monitor.c >>>>>>>> @@ -2573,7 +2573,7 @@ static mon_cmd_t info_cmds[] =3D { >>>>>>>> .help =3D "show the command line history", >>>>>>>> .mhandler.cmd =3D hmp_info_history, >>>>>>>> }, >>>>>>>> -#if defined(TARGET_I386) || defined(TARGET_PPC) || defined(TARG= ET_MIPS) || \ >>>>>>>> +#if defined(TARGET_I386) || defined(TARGET_MIPS) || \ >>>>>>>> defined(TARGET_LM32) || (defined(TARGET_SPARC) && !defined(= TARGET_SPARC64)) >>>>>>>> { >>>>>>>> .name =3D "irq", >>>>>>>> >>>>>>> >>>>>>> Perhaps we can a use a "#if defined(CONFIG_I8259) || >>>>>>> defined(CONFIG_LM32) || (defined(TARGE_SPARC) && >>>>>>> !defined(TARGET_SPARC64))" instead, so we keep the command for PR= eP ? >>>>>> >>>>>> AFAIK this currently won't work since CONFIG_I8259 is only defined= for >>>>>> the Makefiles, but not for the C pre-processor :-( >>>>> >>>>> Yes, I see that afterward, but ... >>>>> >>>>>> So unless somebody fixes that first, I think David's approach is t= he >>>>>> only practicable solution right now. >>>>> >>>>> if you add "config-devices.h" in GENERATED_HEADERS in Makefile.targ= et, >>>>> and include "config-devices.h" in monitor.c, it works (all PREP >>>>> dependencies in default-configs/ppc64-softmmu.mak must be removed t= oo) >>>>> >>>>> But does this change acceptable for a tiny improvement ? >>>> >>>> In fine, I think we can also do like for sparc: >>>> >>>> defined(TARGET_PPC) && !defined(TARGET_PPC64) >>> >>> Alex specifically requested PReP to be made available in ppc64, too. >> >> Thank you Andreas. >> >> But why ? (I didn't find the answer with google, a link can be helpful= ). http://git.qemu-project.org/?p=3Dqemu.git;a=3Dcommit;h=3Dacbb090b2400f627= a801074c4e3e006c7501bb26 (found by looking at the ppc64-softmmu.mak Git history) Judging by Markus as the reporter, I assume it was a tree-wide analysis that came up with this inconsistency, which I was then asked to fix this way. Andreas >> >> Is there any 64bit PReP ? >> >> BTW using CONFIG_I8259 cannot enable it only for PReP and not for othe= r >> PPC64. So the solution from David is the best. >=20 > For all newer targets (excluding sparc64 etc.) the 64-bit target is > expected to deliver all 32-bit targets as well, for use with KVM in tha= t > bitness or for convenience of installing just one executable. >=20 > Alex is on CC and if you ping him hard enough he might reply himself. ;= ) >=20 > So, generating a header file, like you proposed above, seems like the > most elegant solution to me here. > That won't help the qtest issue I raised on the other patch though, > which would need a QMP lookup as discussed in the ivshmem context. I > rebased that patch on Friday and can look into factoring that out into > libqtest.[ch]. >=20 > Regards, > Andreas >=20 --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)