From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9XxQ-00036E-0y for qemu-devel@nongnu.org; Mon, 29 Jun 2015 08:14:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9XxM-0006Z2-0x for qemu-devel@nongnu.org; Mon, 29 Jun 2015 08:14:39 -0400 Received: from cantor2.suse.de ([195.135.220.15]:44269 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9XUr-00068M-QD for qemu-devel@nongnu.org; Mon, 29 Jun 2015 07:45:09 -0400 Message-ID: <55912FC3.8060406@suse.de> Date: Mon, 29 Jun 2015 13:45:07 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1434488267-32108-1-git-send-email-aurelien@aurel32.net> <5582EBF1.2020600@twiddle.net> In-Reply-To: <5582EBF1.2020600@twiddle.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-s390x: fix MOVE LONG instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , Aurelien Jarno , qemu-devel@nongnu.org On 06/18/15 18:04, Richard Henderson wrote: > On 06/16/2015 04:57 PM, Aurelien Jarno wrote: >> The MOVE LONG instruction should pad the destination operand with the >> byte from bit positions 32-39 of the source length (r2 + 1), not with >> the same byte in the source address. >> >> Cc: Alexander Graf >> Cc: Richard Henderson >> Signed-off-by: Aurelien Jarno >> --- >> target-s390x/mem_helper.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Richard Henderson Thanks, applied to s390-next. Alex