* [Qemu-devel] [PATCH] target-s390x: fix MOVE LONG instruction
@ 2015-06-16 20:57 Aurelien Jarno
2015-06-18 16:04 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: Aurelien Jarno @ 2015-06-16 20:57 UTC (permalink / raw)
To: qemu-devel; +Cc: Alexander Graf, Aurelien Jarno, Richard Henderson
The MOVE LONG instruction should pad the destination operand with the
byte from bit positions 32-39 of the source length (r2 + 1), not with
the same byte in the source address.
Cc: Alexander Graf <agraf@suse.de>
Cc: Richard Henderson <rth@twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
target-s390x/mem_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-s390x/mem_helper.c b/target-s390x/mem_helper.c
index 3ccbeb9..9f0eb1e 100644
--- a/target-s390x/mem_helper.c
+++ b/target-s390x/mem_helper.c
@@ -550,7 +550,7 @@ uint32_t HELPER(mvcl)(CPUS390XState *env, uint32_t r1, uint32_t r2)
uint64_t dest = get_address_31fix(env, r1);
uint64_t srclen = env->regs[r2 + 1] & 0xffffff;
uint64_t src = get_address_31fix(env, r2);
- uint8_t pad = src >> 24;
+ uint8_t pad = env->regs[r2 + 1] >> 24;
uint8_t v;
uint32_t cc;
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] target-s390x: fix MOVE LONG instruction
2015-06-16 20:57 [Qemu-devel] [PATCH] target-s390x: fix MOVE LONG instruction Aurelien Jarno
@ 2015-06-18 16:04 ` Richard Henderson
2015-06-29 11:45 ` Alexander Graf
0 siblings, 1 reply; 3+ messages in thread
From: Richard Henderson @ 2015-06-18 16:04 UTC (permalink / raw)
To: Aurelien Jarno, qemu-devel; +Cc: Alexander Graf
On 06/16/2015 04:57 PM, Aurelien Jarno wrote:
> The MOVE LONG instruction should pad the destination operand with the
> byte from bit positions 32-39 of the source length (r2 + 1), not with
> the same byte in the source address.
>
> Cc: Alexander Graf<agraf@suse.de>
> Cc: Richard Henderson<rth@twiddle.net>
> Signed-off-by: Aurelien Jarno<aurelien@aurel32.net>
> ---
> target-s390x/mem_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] target-s390x: fix MOVE LONG instruction
2015-06-18 16:04 ` Richard Henderson
@ 2015-06-29 11:45 ` Alexander Graf
0 siblings, 0 replies; 3+ messages in thread
From: Alexander Graf @ 2015-06-29 11:45 UTC (permalink / raw)
To: Richard Henderson, Aurelien Jarno, qemu-devel
On 06/18/15 18:04, Richard Henderson wrote:
> On 06/16/2015 04:57 PM, Aurelien Jarno wrote:
>> The MOVE LONG instruction should pad the destination operand with the
>> byte from bit positions 32-39 of the source length (r2 + 1), not with
>> the same byte in the source address.
>>
>> Cc: Alexander Graf<agraf@suse.de>
>> Cc: Richard Henderson<rth@twiddle.net>
>> Signed-off-by: Aurelien Jarno<aurelien@aurel32.net>
>> ---
>> target-s390x/mem_helper.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Richard Henderson <rth@twiddle.net>
Thanks, applied to s390-next.
Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-29 12:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-16 20:57 [Qemu-devel] [PATCH] target-s390x: fix MOVE LONG instruction Aurelien Jarno
2015-06-18 16:04 ` Richard Henderson
2015-06-29 11:45 ` Alexander Graf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).