* [Qemu-devel] [PATCH] target-s390x: fix EXECUTE instruction executing TRT
@ 2015-06-21 16:51 Aurelien Jarno
2015-06-29 9:15 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: Aurelien Jarno @ 2015-06-21 16:51 UTC (permalink / raw)
To: qemu-devel
Cc: Paolo Bonzini, Alexander Graf, Aurelien Jarno, Richard Henderson
A break is missing in the EXECUTE instruction, when executing the
TRANSLATE AND TEST instruction.
Reported-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Cc: Alexander Graf <agraf@suse.de>
Cc: Richard Henderson <rth@twiddle.net>
---
target-s390x/mem_helper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target-s390x/mem_helper.c b/target-s390x/mem_helper.c
index 9f0eb1e..6f8bd79 100644
--- a/target-s390x/mem_helper.c
+++ b/target-s390x/mem_helper.c
@@ -482,6 +482,7 @@ uint32_t HELPER(ex)(CPUS390XState *env, uint32_t cc, uint64_t v1,
case 0xc00:
helper_tr(env, l, get_address(env, 0, b1, d1),
get_address(env, 0, b2, d2));
+ break;
case 0xd00:
cc = helper_trt(env, l, get_address(env, 0, b1, d1),
get_address(env, 0, b2, d2));
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] target-s390x: fix EXECUTE instruction executing TRT
2015-06-21 16:51 [Qemu-devel] [PATCH] target-s390x: fix EXECUTE instruction executing TRT Aurelien Jarno
@ 2015-06-29 9:15 ` Richard Henderson
2015-06-29 11:45 ` Alexander Graf
0 siblings, 1 reply; 3+ messages in thread
From: Richard Henderson @ 2015-06-29 9:15 UTC (permalink / raw)
To: Aurelien Jarno, qemu-devel; +Cc: Paolo Bonzini, Alexander Graf
On 06/21/2015 05:51 PM, Aurelien Jarno wrote:
> A break is missing in the EXECUTE instruction, when executing the
> TRANSLATE AND TEST instruction.
>
> Reported-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> Cc: Alexander Graf <agraf@suse.de>
> Cc: Richard Henderson <rth@twiddle.net>
Reviewed-By: Richard Henderson <rth@twiddle.net>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] target-s390x: fix EXECUTE instruction executing TRT
2015-06-29 9:15 ` Richard Henderson
@ 2015-06-29 11:45 ` Alexander Graf
0 siblings, 0 replies; 3+ messages in thread
From: Alexander Graf @ 2015-06-29 11:45 UTC (permalink / raw)
To: Richard Henderson, Aurelien Jarno, qemu-devel; +Cc: Paolo Bonzini
On 06/29/15 11:15, Richard Henderson wrote:
> On 06/21/2015 05:51 PM, Aurelien Jarno wrote:
>> A break is missing in the EXECUTE instruction, when executing the
>> TRANSLATE AND TEST instruction.
>>
>> Reported-by: Paolo Bonzini <pbonzini@redhat.com>
>> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>> Cc: Alexander Graf <agraf@suse.de>
>> Cc: Richard Henderson <rth@twiddle.net>
>
> Reviewed-By: Richard Henderson <rth@twiddle.net>
Thanks, applied to s390-next.
Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-29 12:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-21 16:51 [Qemu-devel] [PATCH] target-s390x: fix EXECUTE instruction executing TRT Aurelien Jarno
2015-06-29 9:15 ` Richard Henderson
2015-06-29 11:45 ` Alexander Graf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).