[Qemu-devel] [PATCH] trivial: remove trailing newline from error_report

[Qemu-devel] [PATCH] trivial: remove trailing newline from error_report

[John Snow]

Minor cleanup.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 hw/vfio/platform.c | 2 +-
 net/tap-linux.c    | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c
index 5c678b9..932d631 100644
--- a/hw/vfio/platform.c
+++ b/hw/vfio/platform.c
@@ -225,7 +225,7 @@ static void vfio_intp_interrupt(VFIOINTp *intp)
 
     ret = event_notifier_test_and_clear(&intp->interrupt);
     if (!ret) {
-        error_report("Error when clearing fd=%d (ret = %d)\n",
+        error_report("Error when clearing fd=%d (ret = %d)",
                      event_notifier_get_fd(&intp->interrupt), ret);
     }
 
diff --git a/net/tap-linux.c b/net/tap-linux.c
index 394f2a6..5bd9d21 100644
--- a/net/tap-linux.c
+++ b/net/tap-linux.c
@@ -211,7 +211,7 @@ int tap_fd_set_vnet_le(int fd, int is_le)
         return -errno;
     }
 
-    error_report("TUNSETVNETLE ioctl() failed: %s.\n", strerror(errno));
+    error_report("TUNSETVNETLE ioctl() failed: %s.", strerror(errno));
     abort();
 }
 
@@ -228,7 +228,7 @@ int tap_fd_set_vnet_be(int fd, int is_be)
         return -errno;
     }
 
-    error_report("TUNSETVNETBE ioctl() failed: %s.\n", strerror(errno));
+    error_report("TUNSETVNETBE ioctl() failed: %s.", strerror(errno));
     abort();
 }
 
-- 
2.1.0

Re: [Qemu-devel] [PATCH] trivial: remove trailing newline from error_report

[John Snow]

On 06/29/2015 04:25 PM, John Snow wrote:
> Minor cleanup.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  hw/vfio/platform.c | 2 +-
>  net/tap-linux.c    | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c
> index 5c678b9..932d631 100644
> --- a/hw/vfio/platform.c
> +++ b/hw/vfio/platform.c
> @@ -225,7 +225,7 @@ static void vfio_intp_interrupt(VFIOINTp *intp)
>  
>      ret = event_notifier_test_and_clear(&intp->interrupt);
>      if (!ret) {
> -        error_report("Error when clearing fd=%d (ret = %d)\n",
> +        error_report("Error when clearing fd=%d (ret = %d)",
>                       event_notifier_get_fd(&intp->interrupt), ret);
>      }
>  
> diff --git a/net/tap-linux.c b/net/tap-linux.c
> index 394f2a6..5bd9d21 100644
> --- a/net/tap-linux.c
> +++ b/net/tap-linux.c
> @@ -211,7 +211,7 @@ int tap_fd_set_vnet_le(int fd, int is_le)
>          return -errno;
>      }
>  
> -    error_report("TUNSETVNETLE ioctl() failed: %s.\n", strerror(errno));
> +    error_report("TUNSETVNETLE ioctl() failed: %s.", strerror(errno));
>      abort();
>  }
>  
> @@ -228,7 +228,7 @@ int tap_fd_set_vnet_be(int fd, int is_be)
>          return -errno;
>      }
>  
> -    error_report("TUNSETVNETBE ioctl() failed: %s.\n", strerror(errno));
> +    error_report("TUNSETVNETBE ioctl() failed: %s.", strerror(errno));
>      abort();
>  }
>  
> 

NACK, missed one, see v2