From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43542)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1Z9g6h-000260-KN
	for qemu-devel@nongnu.org; Mon, 29 Jun 2015 16:56:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1Z9g6e-0005FP-4x
	for qemu-devel@nongnu.org; Mon, 29 Jun 2015 16:56:47 -0400
Message-ID: <5591B10A.8070807@redhat.com>
Date: Mon, 29 Jun 2015 16:56:42 -0400
From: John Snow <jsnow@redhat.com>
MIME-Version: 1.0
References: <1435609557-14137-1-git-send-email-jsnow@redhat.com>
In-Reply-To: <1435609557-14137-1-git-send-email-jsnow@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] trivial: remove trailing newline from
	error_report
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org



On 06/29/2015 04:25 PM, John Snow wrote:
> Minor cleanup.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  hw/vfio/platform.c | 2 +-
>  net/tap-linux.c    | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c
> index 5c678b9..932d631 100644
> --- a/hw/vfio/platform.c
> +++ b/hw/vfio/platform.c
> @@ -225,7 +225,7 @@ static void vfio_intp_interrupt(VFIOINTp *intp)
>  
>      ret = event_notifier_test_and_clear(&intp->interrupt);
>      if (!ret) {
> -        error_report("Error when clearing fd=%d (ret = %d)\n",
> +        error_report("Error when clearing fd=%d (ret = %d)",
>                       event_notifier_get_fd(&intp->interrupt), ret);
>      }
>  
> diff --git a/net/tap-linux.c b/net/tap-linux.c
> index 394f2a6..5bd9d21 100644
> --- a/net/tap-linux.c
> +++ b/net/tap-linux.c
> @@ -211,7 +211,7 @@ int tap_fd_set_vnet_le(int fd, int is_le)
>          return -errno;
>      }
>  
> -    error_report("TUNSETVNETLE ioctl() failed: %s.\n", strerror(errno));
> +    error_report("TUNSETVNETLE ioctl() failed: %s.", strerror(errno));
>      abort();
>  }
>  
> @@ -228,7 +228,7 @@ int tap_fd_set_vnet_be(int fd, int is_be)
>          return -errno;
>      }
>  
> -    error_report("TUNSETVNETBE ioctl() failed: %s.\n", strerror(errno));
> +    error_report("TUNSETVNETBE ioctl() failed: %s.", strerror(errno));
>      abort();
>  }
>  
> 

NACK, missed one, see v2