From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9rxm-0003jV-Kc for qemu-devel@nongnu.org; Tue, 30 Jun 2015 05:36:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9rxj-0003t9-6g for qemu-devel@nongnu.org; Tue, 30 Jun 2015 05:36:22 -0400 Message-ID: <559262FF.5010105@suse.de> Date: Tue, 30 Jun 2015 11:35:59 +0200 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1435556214-2916-1-git-send-email-david@gibson.dropbear.id.au> <1435556214-2916-3-git-send-email-david@gibson.dropbear.id.au> <55911D6A.7000800@suse.de> <20150630034410.GH26353@voom.redhat.com> <20150630044812.GI26353@voom.redhat.com> In-Reply-To: <20150630044812.GI26353@voom.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IDo8UkXbf0wJ6e1F7bESgKqhulXJqKJ4k" Subject: Re: [Qemu-devel] [PATCH 2/4] Allow ISA bus to be configured out List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: lvivier@redhat.com, agraf@suse.de, thuth@redhat.com, armbru@redhat.com, Anthony Green , qemu-devel@nongnu.org, lcapitulino@redhat.com, qemu-ppc@nongnu.org, Paolo Bonzini , Guan Xuetao This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IDo8UkXbf0wJ6e1F7bESgKqhulXJqKJ4k Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Am 30.06.2015 um 06:48 schrieb David Gibson: > On Tue, Jun 30, 2015 at 01:44:10PM +1000, David Gibson wrote: >> On Mon, Jun 29, 2015 at 12:26:50PM +0200, Andreas F=E4rber wrote: >>> Am 29.06.2015 um 07:36 schrieb David Gibson: >>>> Currently, the code to handle the legacy ISA bus is always included = in >>>> qemu. However there are lots of platforms that don't include ISA le= gacy >>>> devies, and quite a few that have never used ISA legacy devices at a= ll. >>>> >>>> This patch allows the ISA bus code to be disabled in the configurati= on for >>>> platforms where it doesn't make sense. For now, the default configs= are >>>> adjusted to include ISA on all platforms including PCI (since >>>> CONFIG_IDE_CORE which is in pci.mak requires ISA support) and also s= everal >>>> others which include ISA devices. We may want to pare this down in = future. >>> >>> PCI also allows to have a PCI-ISA bridge such as the i82378, which me= ans >>> that all PCI platforms can potentially obtain an actual ISA bus. So a= t >>> least the commit message could use a makeover to avoid someone touchi= ng >>> IDE to blindly disable the dependency. >> >> Sorry, I'm not quite following what you're getting at here. >> >>> You'd also need to think about the qtests then: >>> >>> $ git grep i82378 -- tests/ >>> tests/endianness-test.c: { "ppc", "g3beige", 0xfe000000, .bswap =3D= >>> true, .superio =3D "i82378" }, >>> tests/endianness-test.c: { "ppc", "bamboo", 0xe8000000, .bswap =3D= >>> true, .superio =3D "i82378" }, >>> tests/endianness-test.c: { "ppc64", "mac99", 0xf2000000, .bswap =3D= >>> true, .superio =3D "i82378" }, >>> tests/endianness-test.c: .bswap =3D true, .superio =3D "i82378" = }, >>> tests/endianness-test.c: { "sh4", "r2d", 0xfe240000, .superio =3D >>> "i82378" }, >>> tests/endianness-test.c: { "sh4eb", "r2d", 0xfe240000, .bswap =3D = true, >>> .superio =3D "i82378" }, >> >> Ah, good point. I'll need to rework for that, >=20 > Actually.. on second thoughts.. >=20 > CONFIG_I82378 already exists, and will break those tests of disabled. >=20 > So while making the tests more robust against config changes would be > a good thing in general, I don't think it's in the scope of what I'm > trying to do here - making ISA configurable won't make these tests any > more broken with nonstandard configs than they already are. I am mainly saying that your commit message is misleading. CONFIG_IDE_CORE is not the only reason that pci.mak needs CONFIG_ISA_BUS=3Dy, as you make it sound. The other problem is that we don't have Kconfig yet, so we have no way of modeling that I82378 depends on ISA_BUS, therefore either pci.mak (as done here) or ppc-softmmu.mak and ppc64-softmmu.mak need CONFIG_ISA_BUS=3Dy. And due to= the qtest either sh4/sh4eb need that same dependency too, or the test needs to be changed. So please either revise the commit message when you resend, or you'll need to repeat CONFIG_ISA_BUS=3Dy for ppc, ppc64, sh4, sh4eb. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB= 21284 (AG N=FCrnberg) --IDo8UkXbf0wJ6e1F7bESgKqhulXJqKJ4k Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVkmMFAAoJEPou0S0+fgE/xU4P/15TUvKkHmuF8LK53K5T08e1 q2F0lWSuJW+AUcDH9NXQNhrTnfiacR6UBscB4biwsQgsYMO+DKrVYz+pIyn3XHRT 84DpNuHFINVE4cTdbeMGBBJgj+DQ4FHjkE3bTTZOvl7w0231UhrAQxnWTLb4DHkI xY0AV4Cgs9K1sQjOCCCGjmdwShIXaoqSJ3t1aphuCc3zcY0n5/6rHu2lPnIrFbzS pMiNuX6eIVGeHfrzatwBiObP5i2GjhVVoCd0dk1fosVBjaHVJ1zc0smZ8gEnTTvL NKTi+lpcAxAmlN2nu2SnpOGN75yfQOgU1fyPCpUhUSn9QRR4+WiPrKxIOXHsBPz5 f/SVUlIFUGqxFBcYAPGqEXlOXsh4pOsRME34lh5GH/T+0SmYyfFPJmkk451pzI5r F/uk0U1LbLjFgijekUsRMdAF+qwC+oAEc7LQ6rygqz06a5ZdThC1j186yQfZxpE1 J24+7YeaTTt7jEw4lCGFwgAzggbF+7hhI3TN9oWLZ/K0tQy2fESCXPYAX6oLHoRM yvd76vKN4rtUl3Z0/n7F5/DcbhgZ3odcc5PdYo8teFW6zQRGFEOTIeknTh2LOXE3 y/QitNu8CmQ7Cm71AY2XaRqkKAioyewD8YMhV5wIIJmu6xnS6K/DRSPVg8yrPYZk QAaWkoj/QKBmomT/rOnj =E5Ds -----END PGP SIGNATURE----- --IDo8UkXbf0wJ6e1F7bESgKqhulXJqKJ4k--