From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40562) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9vQV-0001ok-T2 for qemu-devel@nongnu.org; Tue, 30 Jun 2015 09:18:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9vQS-0001Rc-61 for qemu-devel@nongnu.org; Tue, 30 Jun 2015 09:18:15 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:12840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9vQS-0001RF-19 for qemu-devel@nongnu.org; Tue, 30 Jun 2015 09:18:12 -0400 Message-ID: <55929712.4090509@imgtec.com> Date: Tue, 30 Jun 2015 14:18:10 +0100 From: Leon Alrae MIME-Version: 1.0 References: <0DA23CC379F5F945ACB41CF394B98277210E9658@LEMAIL01.le.imgtec.org> In-Reply-To: <0DA23CC379F5F945ACB41CF394B98277210E9658@LEMAIL01.le.imgtec.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] linux-user: Fix MIPS N64 trap and break instruction bug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Bennett , "qemu-devel@nongnu.org" Cc: Riku Voipio On 29/06/2015 11:20, Andrew Bennett wrote: > From: Andrew Bennett > > For the MIPS N64 ABI when QEMU reads the break/trap instruction so that > it can inspect the break/trap code it reads 8 rather than 4 bytes > which means it finds the code field from the instruction after the > break/trap instruction. This then causes the break/trap handling > code to fail because it does not understand the code number. > > The fix forces QEMU to always read 4 bytes of instruction data rather > than deciding how much to read based on the ABI. > > Signed-off-by: Andrew Bennett > --- > linux-user/main.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Leon Alrae Thanks, Leon