From: Dominik Csapak <d.csapak@proxmox.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 0/3] qapi: return ShutdownCause for events
Date: Wed, 5 Dec 2018 16:06:22 +0100 [thread overview]
Message-ID: <5592d444-4527-89b8-4a0a-f32c6b5beb69@proxmox.com> (raw)
In-Reply-To: <87a7lkuptr.fsf@dusky.pond.sub.org>
On 12/5/18 1:21 PM, Markus Armbruster wrote:
> Dominik Csapak <d.csapak@proxmox.com> writes:
>
>> This series improves the QMP SHUTDOWN and RESET events by adding
>> the ShutdownCause as additional parameter and splitting
>> the HOST_QMP reason into HOST_QMP_QUIT and HOST_QMP_SYSTEM_RESET
>> to be able to detect the difference between them when using '--no-reboot'
>>
>> this is an alternative to my previous patches[1][2] which
>> added an exit-script/added a 'reset' argument to the events
>>
>> 1: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg00697.html
>> 2: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg01271.html
>
> Next time, please add the Reviewed-bys you got for the previous version
> to your commit messages, unless the commits changed enough to warrant
> another round of review.
Yes of course, sorry for that.
Thank you again for the review.
>
> For the record, series again
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
>
next prev parent reply other threads:[~2018-12-05 15:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 11:01 [Qemu-devel] [PATCH v3 0/3] qapi: return ShutdownCause for events Dominik Csapak
2018-12-05 11:01 ` [Qemu-devel] [PATCH v3 1/3] qapi: Turn ShutdownCause into QAPI enum Dominik Csapak
2018-12-05 11:01 ` [Qemu-devel] [PATCH v3 2/3] qapi: Add reason to SHUTDOWN and RESET events Dominik Csapak
2018-12-05 11:01 ` [Qemu-devel] [PATCH v3 3/3] qapi: Split host-qmp into quit and system-reset Dominik Csapak
2018-12-05 12:21 ` [Qemu-devel] [PATCH v3 0/3] qapi: return ShutdownCause for events Markus Armbruster
2018-12-05 15:06 ` Dominik Csapak [this message]
2018-12-06 13:29 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5592d444-4527-89b8-4a0a-f32c6b5beb69@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).