From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZADt7-0004nX-0x for qemu-devel@nongnu.org; Wed, 01 Jul 2015 05:01:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZADt0-0004Mp-UK for qemu-devel@nongnu.org; Wed, 01 Jul 2015 05:01:00 -0400 Received: from mail-qg0-x229.google.com ([2607:f8b0:400d:c04::229]:34254) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZADt0-0004Lz-Gw for qemu-devel@nongnu.org; Wed, 01 Jul 2015 05:00:54 -0400 Received: by qgii30 with SMTP id i30so15617339qgi.1 for ; Wed, 01 Jul 2015 02:00:53 -0700 (PDT) Sender: Richard Henderson References: <20150629072310.388.48661.stgit@PASHA-ISP> <20150629072317.388.56900.stgit@PASHA-ISP> From: Richard Henderson Message-ID: <5593AC3A.9030109@twiddle.net> Date: Wed, 1 Jul 2015 10:00:42 +0100 MIME-Version: 1.0 In-Reply-To: <20150629072317.388.56900.stgit@PASHA-ISP> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 1/5] softmmu: add helper function to pass through retaddr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, rth7680@gmail.com, leon.alrae@imgtec.com, agraf@suse.de, aurelien@aurel32.net On 06/29/2015 08:23 AM, Pavel Dovgalyuk wrote: > This patch introduces several helpers to pass return address > which points to the TB. Correct return address allows correct > restoring of the guest PC and icount. These functions should be used when > helpers embedded into TB invoke memory operations. > > Signed-off-by: Pavel Dovgalyuk > --- > include/exec/cpu_ldst_template.h | 59 +++++++++++++++++++++++++++++++++----- > softmmu_template.h | 6 ---- > tcg/tcg.h | 23 +++++++++++++++ > 3 files changed, 74 insertions(+), 14 deletions(-) Reviewed-by: Richard Henderson r~