From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60285) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAJh1-0006zk-BR for qemu-devel@nongnu.org; Wed, 01 Jul 2015 11:12:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAJgy-0006ir-I0 for qemu-devel@nongnu.org; Wed, 01 Jul 2015 11:12:55 -0400 Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:36515) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAJgy-0006in-9Z for qemu-devel@nongnu.org; Wed, 01 Jul 2015 11:12:52 -0400 Received: by widjy10 with SMTP id jy10so60635019wid.1 for ; Wed, 01 Jul 2015 08:12:51 -0700 (PDT) Sender: Paolo Bonzini References: <1435664007-4965-1-git-send-email-den@openvz.org> <1435664007-4965-9-git-send-email-den@openvz.org> From: Paolo Bonzini Message-ID: <55940371.9070002@redhat.com> Date: Wed, 1 Jul 2015 17:12:49 +0200 MIME-Version: 1.0 In-Reply-To: <1435664007-4965-9-git-send-email-den@openvz.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 8/9] kvm/x86: add sending hyper-v crash notification to user space List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Andrey Smetanin , Gleb Natapov , qemu-devel@nongnu.org, kvm@vger.kernel.org On 30/06/2015 13:33, Denis V. Lunev wrote: > From: Andrey Smetanin > > Sending of notification is done by exiting vcpu to user space > if KVM_REQ_HV_CRASH is enabled for vcpu. kvm_run structure > will contains system_event with type KVM_SYSTEM_EVENT_CRASH > and flag KVM_SYSTEM_EVENT_FL_HV_CRASH to clarify that > crash occures inside Hyper-V based guest. This needs to be documented in Documentation/virtual/kvm/api.txt. Also, please rename KVM_SYSTEM_EVENT_FL_HV_CRASH to KVM_SYSTEM_EVENT_FLAG_HV_CRASH and move it to arch/x86/include/uapi/asm/kvm.h. You do not need to send the whole series again; just resend this one patch. Paolo > Signed-off-by: Andrey Smetanin > Signed-off-by: Denis V. Lunev > CC: Paolo Bonzini > CC: Gleb Natapov > --- > arch/x86/kvm/x86.c | 8 ++++++++ > include/uapi/linux/kvm.h | 2 ++ > 2 files changed, 10 insertions(+) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 47b7507..55a4b92 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -6264,6 +6264,14 @@ static int vcpu_enter_guest(struct kvm_vcpu *vcpu) > vcpu_scan_ioapic(vcpu); > if (kvm_check_request(KVM_REQ_APIC_PAGE_RELOAD, vcpu)) > kvm_vcpu_reload_apic_access_page(vcpu); > + if (kvm_check_request(KVM_REQ_HV_CRASH, vcpu)) { > + vcpu->run->exit_reason = KVM_EXIT_SYSTEM_EVENT; > + vcpu->run->system_event.type = KVM_SYSTEM_EVENT_CRASH; > + vcpu->run->system_event.flags = > + KVM_SYSTEM_EVENT_FL_HV_CRASH; > + r = 0; > + goto out; > + } > } > > if (kvm_check_request(KVM_REQ_EVENT, vcpu) || req_int_win) { > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index 716ad4a..eefb8b9 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h > @@ -317,6 +317,8 @@ struct kvm_run { > struct { > #define KVM_SYSTEM_EVENT_SHUTDOWN 1 > #define KVM_SYSTEM_EVENT_RESET 2 > +#define KVM_SYSTEM_EVENT_CRASH 3 > +#define KVM_SYSTEM_EVENT_FL_HV_CRASH (1ULL << 0) > __u32 type; > __u64 flags; > } system_event; >