From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46737)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1ZAKKx-0005zp-Sr
	for qemu-devel@nongnu.org; Wed, 01 Jul 2015 11:54:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1ZAKKv-0002xC-3k
	for qemu-devel@nongnu.org; Wed, 01 Jul 2015 11:54:11 -0400
Received: from mx2.parallels.com ([199.115.105.18]:33291)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1ZAKKu-0002vu-Tw
	for qemu-devel@nongnu.org; Wed, 01 Jul 2015 11:54:09 -0400
Message-ID: <55940D15.9050108@openvz.org>
Date: Wed, 1 Jul 2015 18:53:57 +0300
From: "Denis V. Lunev" <den@openvz.org>
MIME-Version: 1.0
References: <1435664007-4965-1-git-send-email-den@openvz.org>
	<1435664007-4965-4-git-send-email-den@openvz.org>
	<55940074.1010606@redhat.com>
In-Reply-To: <55940074.1010606@redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/9] kvm: add hyper-v crash msrs values
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Andrey Smetanin <asmetanin@virtuozzo.com>, Gleb Natapov <gleb@kernel.org>, qemu-devel@nongnu.org, kvm@vger.kernel.org, Peter Hornyack <peterhornyack@google.com>

On 01/07/15 18:00, Paolo Bonzini wrote:
>
> On 30/06/2015 13:33, Denis V. Lunev wrote:
>> +#define HV_X64_MSR_CRASH_CTL_NOTIFY		(1ULL << 63)
>> +#define HV_X64_MSR_CRASH_CTL_CONTENTS	\
>> +		(HV_X64_MSR_CRASH_CTL_NOTIFY)
> Why is HV_X64_MSR_CRASH_CTL_CONTENTS needed?  Can I just remove it?
>
> Paolo
this was a direct request from Peter Hornyack <peterhornyack@google.com>

"I suggest here:

#define HV_X64_MSR_CRASH_CTL_CONTENTS  \
         (HV_CRASH_CTL_CRASH_NOTIFY)

To allow for more crash actions to be added in the future."

Den