From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40187) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZALAR-0004FE-2P for qemu-devel@nongnu.org; Wed, 01 Jul 2015 12:47:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZALAN-0006hl-SG for qemu-devel@nongnu.org; Wed, 01 Jul 2015 12:47:23 -0400 Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:32920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZALAN-0006eB-Dz for qemu-devel@nongnu.org; Wed, 01 Jul 2015 12:47:19 -0400 Received: by wiwl6 with SMTP id l6so171281469wiw.0 for ; Wed, 01 Jul 2015 09:47:18 -0700 (PDT) Sender: Paolo Bonzini References: <1435664007-4965-1-git-send-email-den@openvz.org> <1435664007-4965-8-git-send-email-den@openvz.org> From: Paolo Bonzini Message-ID: <55941993.6090502@redhat.com> Date: Wed, 1 Jul 2015 18:47:15 +0200 MIME-Version: 1.0 In-Reply-To: <1435664007-4965-8-git-send-email-den@openvz.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 7/9] kvm/x86: added hyper-v crash data and ctl msr's get/set'ers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Andrey Smetanin , Gleb Natapov , qemu-devel@nongnu.org, kvm@vger.kernel.org On 30/06/2015 13:33, Denis V. Lunev wrote: > +static int kvm_hv_msr_set_crash_ctl(struct kvm_vcpu *vcpu, u64 data, bool host) > +{ > + struct kvm_hv *hv = &vcpu->kvm->arch.hyperv; > + > + if (host) > + hv->hv_crash_ctl = data; > + You need to check against HV_X64_MSR_CRASH_CTL_CONTENTS here (or HV_X64_MSR_CRASH_CTL_NOTIFY) here. Paolo