From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAYPS-0007de-3g for qemu-devel@nongnu.org; Thu, 02 Jul 2015 02:55:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAYPM-0004kn-RQ for qemu-devel@nongnu.org; Thu, 02 Jul 2015 02:55:46 -0400 Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:37592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAYPL-0004iO-JV for qemu-devel@nongnu.org; Thu, 02 Jul 2015 02:55:40 -0400 Received: by wicgi11 with SMTP id gi11so64318134wic.0 for ; Wed, 01 Jul 2015 23:55:38 -0700 (PDT) Sender: Paolo Bonzini References: <1432686576-14816-1-git-send-email-pcacjr@zytor.com> <1435514338-20227-1-git-send-email-pcacjr@zytor.com> <1435514338-20227-3-git-send-email-pcacjr@zytor.com> <5593E8B1.6000300@redhat.com> <20150701152733-mutt-send-email-mst@redhat.com> <20150701223036.38a22307@zytor.com> From: Paolo Bonzini Message-ID: <5594E067.2030002@redhat.com> Date: Thu, 2 Jul 2015 08:55:35 +0200 MIME-Version: 1.0 In-Reply-To: <20150701223036.38a22307@zytor.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v8 3/3] ich9: implement strap SPKR pin logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paulo Alcantara , "Michael S. Tsirkin" Cc: seabios@seabios.org, Paulo Alcantara , qemu-devel@nongnu.org, kraxel@redhat.com On 02/07/2015 03:30, Paulo Alcantara wrote: > No, the iTCO_wdt driver won't fail to start. It actually depends on > whether RCBA BAR is set. However, ICH9 will just ignore whether > NO_REBOOT is set or unset when SPKR pin is high. This is the code I was referring to, in iTCO_wdt_start: /* disable chipset's NO_REBOOT bit */ if (iTCO_wdt_unset_NO_REBOOT_bit()) { spin_unlock(&iTCO_wdt_private.io_lock); pr_err("failed to reset NO_REBOOT flag, reboot disabled by hardware/BIOS\n"); return -EIO; } Paolo