From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46251)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZAZKl-0005MV-E8
	for qemu-devel@nongnu.org; Thu, 02 Jul 2015 03:55:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZAZKk-0005WZ-C3
	for qemu-devel@nongnu.org; Thu, 02 Jul 2015 03:54:59 -0400
References: <AB4CFA84-0BE1-41D1-A825-E879FD3EF2CB@gmail.com>
	<5594E5C7.9010101@redhat.com> <5594EAB6.5070607@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <5594EE47.10809@redhat.com>
Date: Thu, 2 Jul 2015 09:54:47 +0200
MIME-Version: 1.0
In-Reply-To: <5594EAB6.5070607@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] raw-posix.c: remove raw device access for
	cdrom
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <lvivier@redhat.com>, Programmingkid <programmingkidx@gmail.com>, Stefan Hajnoczi <stefanha@gmail.com>, Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>, John Snow <jsnow@redhat.com>, qemu-devel qemu-devel <qemu-devel@nongnu.org>, Qemu-block <qemu-block@nongnu.org>



On 02/07/2015 09:39, Laurent Vivier wrote:
> This code seems to be a cut'n'paste of an Apple example (bad...):
> 
> https://developer.apple.com/library/mac/samplecode/CDROMSample/Listings/CDROMSample_CDROMSample_c.html
> 
> Without this interesting comment:
> 
>     Add "r" before the BSD node name from the I/O Registry to specify
>     the raw disknode. The raw disk nodes receive I/O requests directly
>     and do not go through the buffer cache.

Ok, so that's not too bad.

Paolo