From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAaNq-0005Mx-9l for qemu-devel@nongnu.org; Thu, 02 Jul 2015 05:02:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAaNn-0008Hc-1O for qemu-devel@nongnu.org; Thu, 02 Jul 2015 05:02:14 -0400 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:51849) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAaNm-0008HN-FA for qemu-devel@nongnu.org; Thu, 02 Jul 2015 05:02:10 -0400 Received: from /spool/local by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 2 Jul 2015 19:02:01 +1000 Received: from d23relay06.au.ibm.com (d23relay06.au.ibm.com [9.185.63.219]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 80BAB2CE8040 for ; Thu, 2 Jul 2015 19:02:03 +1000 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay06.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t6291rcZ56426576 for ; Thu, 2 Jul 2015 19:02:03 +1000 Received: from d23av04.au.ibm.com (localhost [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t6291Se1014517 for ; Thu, 2 Jul 2015 19:01:29 +1000 Message-ID: <5594FDD6.2020902@linux.vnet.ibm.com> Date: Thu, 02 Jul 2015 17:01:10 +0800 From: tu bo MIME-Version: 1.0 References: <1432870329-7502-1-git-send-email-tubo@linux.vnet.ibm.com> <1432870329-7502-8-git-send-email-tubo@linux.vnet.ibm.com> In-Reply-To: <1432870329-7502-8-git-send-email-tubo@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v10 7/7] qemu-iotests: s390x: fix test 130 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, armbru@redhat.com, mimu@linux.vnet.ibm.com, mreitz@redhat.com I got one issue after running checkpatch.pl below, [gavin@oc6333346435 qemu]$ ./scripts/checkpatch.pl home/gavin/patch/v8/0007-qemu-iotests-s390x-fix-test-130.patch // ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8// #52: FILE: tests/qemu-iotests/130.out:12:// +(qemu) commit testdisk// ^// ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8// #60: FILE: tests/qemu-iotests/130.out:19:// +(qemu) commit testdisk// ^// total: 2 errors, 0 warnings, 36 lines checked/ The reason is that 130.out contains some non-text data. Do I need to report an issue to checkpatch.pl, or ignore this error message? thanks On 05/29/2015 11:32 AM, Bo Tu wrote: > The default device id of hard disk on the s390 platform is "virtio0" > which differs to the "ide0-hd0" for the x86 platform. Setting id in > the drive definition, ie:"qemu -drive id=testdisk", will be the same > on all platforms. > > Reviewed-by: Max Reitz > Signed-off-by: Bo Tu > --- > tests/qemu-iotests/130 | 8 ++++---- > tests/qemu-iotests/130.out | 4 ++-- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/tests/qemu-iotests/130 b/tests/qemu-iotests/130 > index bc26247..9209992 100755 > --- a/tests/qemu-iotests/130 > +++ b/tests/qemu-iotests/130 > @@ -59,8 +59,8 @@ echo > # bdrv_make_empty() involves a header update for qcow2 > > # Test that a backing file isn't written > -_launch_qemu -drive file="$TEST_IMG",backing.file.filename="$TEST_IMG.base" > -_send_qemu_cmd $QEMU_HANDLE "commit ide0-hd0" "(qemu)" > +_launch_qemu -drive id=testdisk,file="$TEST_IMG",backing.file.filename="$TEST_IMG.base" > +_send_qemu_cmd $QEMU_HANDLE "commit testdisk" "(qemu)" > _send_qemu_cmd $QEMU_HANDLE '' '(qemu)' > _cleanup_qemu > _img_info | _filter_img_info > @@ -68,8 +68,8 @@ _img_info | _filter_img_info > # Make sure that if there was a backing file that was just overridden on the > # command line, that backing file is retained, with the right format > _make_test_img -F raw -b "$TEST_IMG.orig" 64M > -_launch_qemu -drive file="$TEST_IMG",backing.file.filename="$TEST_IMG.base",backing.driver=$IMGFMT > -_send_qemu_cmd $QEMU_HANDLE "commit ide0-hd0" "(qemu)" > +_launch_qemu -drive id=testdisk,file="$TEST_IMG",backing.file.filename="$TEST_IMG.base",backing.driver=$IMGFMT > +_send_qemu_cmd $QEMU_HANDLE "commit testdisk" "(qemu)" > _send_qemu_cmd $QEMU_HANDLE '' '(qemu)' > _cleanup_qemu > _img_info | _filter_img_info > diff --git a/tests/qemu-iotests/130.out b/tests/qemu-iotests/130.out > index ea68b5d..9ec9d2a 100644 > --- a/tests/qemu-iotests/130.out > +++ b/tests/qemu-iotests/130.out > @@ -9,14 +9,14 @@ virtual size: 64M (67108864 bytes) > === HMP commit === > > QEMU X.Y.Z monitor - type 'help' for more information > -(qemu) ccocomcommcommicommitcommit commit icommit idcommit idecommit ide0commit ide0-commit ide0-hcommit ide0-hdcommit ide0-hd0 > +(qemu) ccocomcommcommicommitcommit commit tcommit tecommit tescommit testcommit testdcommit testdicommit testdiscommit testdisk > (qemu) > image: TEST_DIR/t.IMGFMT > file format: IMGFMT > virtual size: 64M (67108864 bytes) > Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864 backing_file='TEST_DIR/t.IMGFMT.orig' backing_fmt='raw' > QEMU X.Y.Z monitor - type 'help' for more information > -(qemu) ccocomcommcommicommitcommit commit icommit idcommit idecommit ide0commit ide0-commit ide0-hcommit ide0-hdcommit ide0-hd0 > +(qemu) ccocomcommcommicommitcommit commit tcommit tecommit tescommit testcommit testdcommit testdicommit testdiscommit testdisk > (qemu) > image: TEST_DIR/t.IMGFMT > file format: IMGFMT