From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49503) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAcvv-0001FG-Dm for qemu-devel@nongnu.org; Thu, 02 Jul 2015 07:45:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAcvn-0005qs-HX for qemu-devel@nongnu.org; Thu, 02 Jul 2015 07:45:35 -0400 Received: from e17.ny.us.ibm.com ([129.33.205.207]:48645) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAcvn-0005pU-Bn for qemu-devel@nongnu.org; Thu, 02 Jul 2015 07:45:27 -0400 Received: from /spool/local by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 2 Jul 2015 07:45:26 -0400 Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 96B89C9003C for ; Thu, 2 Jul 2015 07:36:30 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t62BjNbQ51707922 for ; Thu, 2 Jul 2015 11:45:23 GMT Received: from d01av01.pok.ibm.com (localhost [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t62BjNwr001063 for ; Thu, 2 Jul 2015 07:45:23 -0400 Message-ID: <55952452.7050706@linux.vnet.ibm.com> Date: Thu, 02 Jul 2015 07:45:22 -0400 From: Stefan Berger MIME-Version: 1.0 References: <1433762257-1752411-1-git-send-email-stefanb@linux.vnet.ibm.com> <20150623135234.GA13199@redhat.com> <20150623154217.GA15245@redhat.com> In-Reply-To: <20150623154217.GA15245@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 0/4] Extend TPM support with a QEMU-external TPM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Stefan Berger Cc: qemu-devel@nongnu.org, quan.xu@intel.com On 06/23/2015 11:42 AM, Michael S. Tsirkin wrote: > On Tue, Jun 23, 2015 at 11:37:02AM -0400, Stefan Berger wrote: >> "Michael S. Tsirkin" wrote on 06/23/2015 09:52:34 AM: >> >>> From: "Michael S. Tsirkin" >>> To: Stefan Berger >>> Cc: qemu-devel@nongnu.org, quan.xu@intel.com, Stefan Berger/Watson/IBM@IBMUS >>> Date: 06/23/2015 09:52 AM >>> Subject: Re: [PATCH v4 0/4] Extend TPM support with a QEMU-external TPM >>> >>> On Mon, Jun 08, 2015 at 07:17:33AM -0400, Stefan Berger wrote: >>>> The following series of patches extends TPM support with an >>>> external TPM that offers a Linux CUSE (character device in userspace) >>>> interface. This TPM lets each VM access its own private vTPM. >>>> The CUSE TPM supports suspend/resume and migration. Much >>>> out-of-band functionality necessary to control the CUSE TPM is >>>> implemented using ioctls. >>> So the problem is really review. I feel to judge this >>> adequately I'd have to review cuse code too (since >>> no one else did). And unfortunately I don't have the >>> time to do this anytime soon. >> You mean the CUSE code in the kernel and client library? > I mean swtpm in your tree. > >>> As far as I'm concerned, if anyone wants to review >>> and merge these patches, pls go ahead, I have nothing >>> against them. >> Sounds good. Michael, can you pick up these patches here for upstreaming? Regards, Stefan