From: "Andreas Färber" <afaerber@suse.de>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
ehabkost@redhat.com,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
Anthony Green <green@moxielogic.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Michael Walle <michael@walle.cc>,
Paolo Bonzini <pbonzini@redhat.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
Leon Alrae <leon.alrae@imgtec.com>,
rth@twiddle.net, aurelien@aurel32.net, Jia Liu <proljc@gmail.com>
Subject: Re: [Qemu-devel] [PATCH qom v4 7/7] cpus: Change exec_init() arg to cpu, not env
Date: Thu, 02 Jul 2015 17:55:16 +0200 [thread overview]
Message-ID: <55955EE4.6090404@suse.de> (raw)
In-Reply-To: <7988c79d8d73e98a4237d07930d864b8a08b8947.1435112834.git.crosthwaite.peter@gmail.com>
Am 24.06.2015 um 04:31 schrieb Peter Crosthwaite:
> diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h
> index cffd21e..4bf13e0 100644
> --- a/include/exec/exec-all.h
> +++ b/include/exec/exec-all.h
> @@ -88,7 +88,7 @@ void QEMU_NORETURN cpu_io_recompile(CPUState *cpu, uintptr_t retaddr);
> TranslationBlock *tb_gen_code(CPUState *cpu,
> target_ulong pc, target_ulong cs_base, int flags,
> int cflags);
> -void cpu_exec_init(CPUArchState *env, Error **errp);
> +void cpu_exec_init(CPUState *env, Error **errp);
> void QEMU_NORETURN cpu_loop_exit(CPUState *cpu);
>
> #if !defined(CONFIG_USER_ONLY)
Nit: Fixing s/env/cpu/
diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h
index 4bf13e0..a9c1f88 100644
--- a/include/exec/exec-all.h
+++ b/include/exec/exec-all.h
@@ -88,7 +88,7 @@ void QEMU_NORETURN cpu_io_recompile(CPUState *cpu,
uintptr_t retaddr);
TranslationBlock *tb_gen_code(CPUState *cpu,
target_ulong pc, target_ulong cs_base,
int flags,
int cflags);
-void cpu_exec_init(CPUState *env, Error **errp);
+void cpu_exec_init(CPUState *cpu, Error **errp);
void QEMU_NORETURN cpu_loop_exit(CPUState *cpu);
#if !defined(CONFIG_USER_ONLY)
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-07-02 15:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 2:31 [Qemu-devel] [PATCH qom v4 0/7] More core code ENV_GET_CPU removals Peter Crosthwaite
2015-06-24 2:31 ` [Qemu-devel] [PATCH qom v4 1/7] cpus: Add Error argument to cpu_exec_init() Peter Crosthwaite
2015-06-24 13:37 ` Andreas Färber
2015-06-24 2:31 ` [Qemu-devel] [PATCH qom v4 2/7] cpus: Convert cpu_index into a bitmap Peter Crosthwaite
2015-06-24 13:53 ` Andreas Färber
2015-06-24 15:39 ` Andreas Färber
2015-06-24 2:31 ` [Qemu-devel] [PATCH qom v4 3/7] ppc: Move cpu_exec_init() call to realize function Peter Crosthwaite
2015-06-24 2:31 ` [Qemu-devel] [PATCH qom v4 4/7] translate-all: Change tb_flush() env argument to cpu Peter Crosthwaite
2015-06-24 15:30 ` Andreas Färber
2015-06-24 17:06 ` Peter Crosthwaite
2015-06-24 17:23 ` Andreas Färber
2015-06-24 17:29 ` Peter Crosthwaite
2015-06-24 2:31 ` [Qemu-devel] [PATCH qom v4 5/7] gdbserver: _fork: Change fn to accept cpu instead of env Peter Crosthwaite
2015-06-24 2:31 ` [Qemu-devel] [PATCH qom v4 6/7] cpus: Change tcg_cpu_exec() arg to cpu, not env Peter Crosthwaite
2015-06-24 2:31 ` [Qemu-devel] [PATCH qom v4 7/7] cpus: Change exec_init() " Peter Crosthwaite
2015-07-02 15:55 ` Andreas Färber [this message]
2015-06-24 17:13 ` [Qemu-devel] [PATCH qom v4 0/7] More core code ENV_GET_CPU removals Andreas Färber
2015-06-24 17:16 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55955EE4.6090404@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=crosthwaite.peter@gmail.com \
--cc=crosthwaitepeter@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=green@moxielogic.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=jcmvbkbc@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=leon.alrae@imgtec.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=michael@walle.cc \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=proljc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).