From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52418) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAgph-0001vV-5B for qemu-devel@nongnu.org; Thu, 02 Jul 2015 11:55:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAgpc-0003St-VZ for qemu-devel@nongnu.org; Thu, 02 Jul 2015 11:55:25 -0400 Received: from cantor2.suse.de ([195.135.220.15]:43950 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAgpc-0003SI-Pp for qemu-devel@nongnu.org; Thu, 02 Jul 2015 11:55:20 -0400 Message-ID: <55955EE4.6090404@suse.de> Date: Thu, 02 Jul 2015 17:55:16 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <7988c79d8d73e98a4237d07930d864b8a08b8947.1435112834.git.crosthwaite.peter@gmail.com> In-Reply-To: <7988c79d8d73e98a4237d07930d864b8a08b8947.1435112834.git.crosthwaite.peter@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom v4 7/7] cpus: Change exec_init() arg to cpu, not env List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org Cc: Peter Maydell , ehabkost@redhat.com, Peter Crosthwaite , Bastian Koppelmann , Anthony Green , Mark Cave-Ayland , Alexander Graf , Blue Swirl , Max Filippov , Michael Walle , Paolo Bonzini , "Edgar E. Iglesias" , Guan Xuetao , Leon Alrae , rth@twiddle.net, aurelien@aurel32.net, Jia Liu Am 24.06.2015 um 04:31 schrieb Peter Crosthwaite: > diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h > index cffd21e..4bf13e0 100644 > --- a/include/exec/exec-all.h > +++ b/include/exec/exec-all.h > @@ -88,7 +88,7 @@ void QEMU_NORETURN cpu_io_recompile(CPUState *cpu, ui= ntptr_t retaddr); > TranslationBlock *tb_gen_code(CPUState *cpu, > target_ulong pc, target_ulong cs_base, i= nt flags, > int cflags); > -void cpu_exec_init(CPUArchState *env, Error **errp); > +void cpu_exec_init(CPUState *env, Error **errp); > void QEMU_NORETURN cpu_loop_exit(CPUState *cpu); > =20 > #if !defined(CONFIG_USER_ONLY) Nit: Fixing s/env/cpu/ diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index 4bf13e0..a9c1f88 100644 --- a/include/exec/exec-all.h +++ b/include/exec/exec-all.h @@ -88,7 +88,7 @@ void QEMU_NORETURN cpu_io_recompile(CPUState *cpu, uintptr_t retaddr); TranslationBlock *tb_gen_code(CPUState *cpu, target_ulong pc, target_ulong cs_base, int flags, int cflags); -void cpu_exec_init(CPUState *env, Error **errp); +void cpu_exec_init(CPUState *cpu, Error **errp); void QEMU_NORETURN cpu_loop_exit(CPUState *cpu); #if !defined(CONFIG_USER_ONLY) Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; = HRB 21284 (AG N=C3=BCrnberg)