qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: "Andrey Smetanin" <asmetanin@virtuozzo.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org,
	"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 12/12] qemu/kvm/x86: hyper-v crash msrs set/get'ers and migration
Date: Thu, 2 Jul 2015 18:18:21 +0200	[thread overview]
Message-ID: <5595644D.5040706@redhat.com> (raw)
In-Reply-To: <1435853275-5440-13-git-send-email-den@openvz.org>


On 02/07/2015 18:07, Denis V. Lunev wrote:
> +        if (cpu->hyperv_crash &&
> +            kvm_check_extension(cs->kvm_state, KVM_CAP_HYPERV_MSR_CRASH) > 0) {
> +            c->edx |= HV_X64_GUEST_CRASH_MSR_AVAILABLE;
> +            has_msr_hv_crash = true;
> +        }
> +

Please patch kvm_get_supported_msrs instead of adding a capability.  The
QEMU parts are otherwise okay.

Paolo

      reply	other threads:[~2015-07-02 16:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-02 16:07 [Qemu-devel] [PATCH v5 0/12] HyperV equivalent of pvpanic driver Denis V. Lunev
2015-07-02 16:07 ` [Qemu-devel] [PATCH 01/12] kvm/x86: move Hyper-V MSR's/hypercall code into hyperv.c file Denis V. Lunev
2015-07-02 16:07 ` [Qemu-devel] [PATCH 02/12] kvm: introduce vcpu_debug = kvm_debug + vcpu context Denis V. Lunev
2015-07-02 16:07 ` [Qemu-devel] [PATCH 03/12] kvm: add hyper-v crash msrs values Denis V. Lunev
2015-07-02 16:07 ` [Qemu-devel] [PATCH 04/12] kvm/x86: added hyper-v crash msrs into kvm hyperv context Denis V. Lunev
2015-07-02 16:07 ` [Qemu-devel] [PATCH 05/12] kvm: added KVM_REQ_HV_CRASH value to notify qemu about hyper-v crash Denis V. Lunev
2015-07-02 16:07 ` [Qemu-devel] [PATCH 06/12] kvm/x86: mark hyper-v crash msrs as partition wide Denis V. Lunev
2015-07-02 16:07 ` [Qemu-devel] [PATCH 07/12] kvm/x86: added hyper-v crash data and ctl msr's get/set'ers Denis V. Lunev
2015-07-02 16:29   ` Paolo Bonzini
2015-07-02 16:07 ` [Qemu-devel] [PATCH 08/12] kvm/x86: add sending hyper-v crash notification to user space Denis V. Lunev
2015-07-02 16:07 ` [Qemu-devel] [PATCH 09/12] qemu: added qemu_system_guest_panicked() - generic guest panic handler Denis V. Lunev
2015-07-02 16:07 ` [Qemu-devel] [PATCH 10/12] qemu/kvm: added kvm system event crash handler Denis V. Lunev
2015-07-02 16:07 ` [Qemu-devel] [PATCH 11/12] qemu: add crash_occurred flag into CPUState Denis V. Lunev
2015-07-02 16:18   ` Andreas Färber
2015-07-02 16:26     ` Paolo Bonzini
2015-07-02 16:07 ` [Qemu-devel] [PATCH 12/12] qemu/kvm/x86: hyper-v crash msrs set/get'ers and migration Denis V. Lunev
2015-07-02 16:18   ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5595644D.5040706@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=asmetanin@virtuozzo.com \
    --cc=den@openvz.org \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).