From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34873)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZAhC4-0001sM-FL
	for qemu-devel@nongnu.org; Thu, 02 Jul 2015 12:18:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZAhBz-0001jz-CK
	for qemu-devel@nongnu.org; Thu, 02 Jul 2015 12:18:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55500)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZAhBz-0001jv-6l
	for qemu-devel@nongnu.org; Thu, 02 Jul 2015 12:18:27 -0400
References: <1435853275-5440-1-git-send-email-den@openvz.org>
	<1435853275-5440-13-git-send-email-den@openvz.org>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <5595644D.5040706@redhat.com>
Date: Thu, 2 Jul 2015 18:18:21 +0200
MIME-Version: 1.0
In-Reply-To: <1435853275-5440-13-git-send-email-den@openvz.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 12/12] qemu/kvm/x86: hyper-v crash msrs
 set/get'ers and migration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Andrey Smetanin <asmetanin@virtuozzo.com>, qemu-devel@nongnu.org, kvm@vger.kernel.org, =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>


On 02/07/2015 18:07, Denis V. Lunev wrote:
> +        if (cpu->hyperv_crash &&
> +            kvm_check_extension(cs->kvm_state, KVM_CAP_HYPERV_MSR_CRASH) > 0) {
> +            c->edx |= HV_X64_GUEST_CRASH_MSR_AVAILABLE;
> +            has_msr_hv_crash = true;
> +        }
> +

Please patch kvm_get_supported_msrs instead of adding a capability.  The
QEMU parts are otherwise okay.

Paolo