From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAhRi-0005cS-3t for qemu-devel@nongnu.org; Thu, 02 Jul 2015 12:34:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAhRd-0003K6-Tm for qemu-devel@nongnu.org; Thu, 02 Jul 2015 12:34:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32915) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAhRd-0003Jx-Om for qemu-devel@nongnu.org; Thu, 02 Jul 2015 12:34:37 -0400 References: <1435254377-13322-1-git-send-email-jjherne@linux.vnet.ibm.com> <1435254377-13322-2-git-send-email-jjherne@linux.vnet.ibm.com> <20150626180702.GK2186@work-vm> <5593F32F.6090909@redhat.com> <559567F2.4070901@linux.vnet.ibm.com> From: Paolo Bonzini Message-ID: <55956818.2030103@redhat.com> Date: Thu, 2 Jul 2015 18:34:32 +0200 MIME-Version: 1.0 In-Reply-To: <559567F2.4070901@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 1/5] cpu: Provide vcpu throttling interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: jjherne@linux.vnet.ibm.com, "Dr. David Alan Gilbert" Cc: amit.shah@redhat.com, borntraeger@de.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, afaerber@suse.de On 02/07/2015 18:33, Jason J. Herne wrote: > I've made all of the changes you have suggested except adding atomics. I'm having > a bit of trouble figuring out what is needed here. Perhaps I should be using > atomic_read() to read throttle_percentage? If so, I don't undertand why. Rather > than trying to explain everything here I'm going to submit my V4 patches. > If any atomic operations are still necessary with V4 please let me know. Fair enough! Paolo