From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46202) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAhdl-000444-Ld for qemu-devel@nongnu.org; Thu, 02 Jul 2015 12:47:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAhdh-0001fZ-5m for qemu-devel@nongnu.org; Thu, 02 Jul 2015 12:47:09 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48590 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAhdh-0001f0-0U for qemu-devel@nongnu.org; Thu, 02 Jul 2015 12:47:05 -0400 Message-ID: <55956B07.3000109@suse.de> Date: Thu, 02 Jul 2015 18:47:03 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1435855010-30882-1-git-send-email-jjherne@linux.vnet.ibm.com> <1435855010-30882-2-git-send-email-jjherne@linux.vnet.ibm.com> In-Reply-To: <1435855010-30882-2-git-send-email-jjherne@linux.vnet.ibm.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 1/5] cpu: Provide vcpu throttling interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Jason J. Herne" Cc: quintela@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com, borntraeger@de.ibm.com, amit.shah@redhat.com, pbonzini@redhat.com Am 02.07.2015 um 18:36 schrieb Jason J. Herne: > Provide a method to throttle guest cpu execution. CPUState is augmented= with > timeout controls and throttle start/stop functions. To throttle the gue= st cpu > the caller simply has to call the throttle set function and provide a p= ercentage > of throttle time. >=20 > Signed-off-by: Jason J. Herne > Reviewed-by: Matthew Rosato > --- > cpus.c | 66 +++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > include/qom/cpu.h | 38 ++++++++++++++++++++++++++++++++ > 2 files changed, 104 insertions(+) No objections from my side, but the interesting code is outside my area. I feel we (including myself) are abusing include/qom/cpu.h (here there's not even a single CPUState argument) but I don't have a better suggestion. At some point we'll need to revisit the cpu.h vs. cpu-all.h etc. split or even introduce something new. I'm preparing a qom-cpu pull and assume this will go through the migration tree when finalized. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)