From: Dmitry Osipenko <digetx@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2] arm_mptimer: Fix timer shutdown
Date: Thu, 02 Jul 2015 20:52:54 +0300 [thread overview]
Message-ID: <55957A76.3070007@gmail.com> (raw)
In-Reply-To: <CAFEAcA883VR70jZFBHWYav725pB-bk0n5qmG4onz=qQAaeK2Tg@mail.gmail.com>
02.07.2015 20:34, Peter Maydell пишет:
>
> This will now cause us to do the "reload the timer"
> logic if you write a 1 to the control bit when it was
> already 1, which we didn't do before.
>
> The logic I suggested in my previous review
> comment gets this right...
>
> -- PMM
>
The problem with code you suggested is that won't start periodic count after
one-shot tick was completed.
--
Dmitry
next prev parent reply other threads:[~2015-07-02 17:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 21:15 [Qemu-devel] [PATCH] arm_mptimer: Fix timer shutdown Dmitry Osipenko
2015-07-02 9:27 ` Peter Maydell
2015-07-02 12:10 ` Dmitry Osipenko
2015-07-02 17:20 ` [Qemu-devel] [PATCH v2] " Dmitry Osipenko
2015-07-02 17:34 ` Peter Maydell
2015-07-02 17:43 ` Dmitry Osipenko
2015-07-02 17:52 ` Dmitry Osipenko [this message]
2015-07-02 18:09 ` Peter Maydell
2015-07-02 18:43 ` Dmitry Osipenko
2015-07-02 18:50 ` Dmitry Osipenko
2015-07-03 11:41 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55957A76.3070007@gmail.com \
--to=digetx@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).