From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38074)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <digetx@gmail.com>) id 1ZAifW-0006gj-In
	for qemu-devel@nongnu.org; Thu, 02 Jul 2015 13:53:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <digetx@gmail.com>) id 1ZAifS-0002ut-Iu
	for qemu-devel@nongnu.org; Thu, 02 Jul 2015 13:53:02 -0400
Received: from mail-la0-x22c.google.com ([2a00:1450:4010:c03::22c]:36322)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <digetx@gmail.com>) id 1ZAifS-0002up-AE
	for qemu-devel@nongnu.org; Thu, 02 Jul 2015 13:52:58 -0400
Received: by lagc2 with SMTP id c2so66179418lag.3
	for <qemu-devel@nongnu.org>; Thu, 02 Jul 2015 10:52:57 -0700 (PDT)
Message-ID: <55957A76.3070007@gmail.com>
Date: Thu, 02 Jul 2015 20:52:54 +0300
From: Dmitry Osipenko <digetx@gmail.com>
MIME-Version: 1.0
References: <55952A1D.2030806@gmail.com>
	<1435857603-30613-1-git-send-email-digetx@gmail.com>
	<CAFEAcA883VR70jZFBHWYav725pB-bk0n5qmG4onz=qQAaeK2Tg@mail.gmail.com>
In-Reply-To: <CAFEAcA883VR70jZFBHWYav725pB-bk0n5qmG4onz=qQAaeK2Tg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v2] arm_mptimer: Fix timer shutdown
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, QEMU Developers <qemu-devel@nongnu.org>

02.07.2015 20:34, Peter Maydell пишет:
>
> This will now cause us to do the "reload the timer"
> logic if you write a 1 to the control bit when it was
> already 1, which we didn't do before.
>
> The logic I suggested in my previous review
> comment gets this right...
>
> -- PMM
>

The problem with code you suggested is that won't start periodic count after 
one-shot tick was completed.

-- 
Dmitry