From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42482)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <guangrong.xiao@linux.intel.com>) id 1ZAith-0003wC-31
	for qemu-devel@nongnu.org; Thu, 02 Jul 2015 14:07:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <guangrong.xiao@linux.intel.com>) id 1ZAitd-0001ZG-Tn
	for qemu-devel@nongnu.org; Thu, 02 Jul 2015 14:07:41 -0400
Received: from mga03.intel.com ([134.134.136.65]:31835)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <guangrong.xiao@linux.intel.com>) id 1ZAitd-0001ZB-OH
	for qemu-devel@nongnu.org; Thu, 02 Jul 2015 14:07:37 -0400
Message-ID: <55957CCE.6010106@linux.intel.com>
Date: Fri, 03 Jul 2015 02:02:54 +0800
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
MIME-Version: 1.0
References: <1435762232-15543-1-git-send-email-guangrong.xiao@linux.intel.com>	<1435762232-15543-15-git-send-email-guangrong.xiao@linux.intel.com>
	<20150702092345.GC20198@stefanha-thinkpad.redhat.com>
In-Reply-To: <20150702092345.GC20198@stefanha-thinkpad.redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 14/16] nvdimm: support
 NFIT_CMD_GET_CONFIG_SIZE function
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, imammedo@redhat.com, rth@twiddle.net



On 07/02/2015 05:23 PM, Stefan Hajnoczi wrote:
> On Wed, Jul 01, 2015 at 10:50:30PM +0800, Xiao Guangrong wrote:
>> +static uint32_t dsm_cmd_config_size(struct dsm_buffer *in, struct dsm_out *out)
>> +{
>> +    GSList *list = get_nvdimm_built_list();
>> +    PCNVDIMMDevice *nvdimm = get_nvdimm_device_by_handle(list, in->handle);
>> +    uint32_t status = NFIT_STATUS_NON_EXISTING_MEM_DEV;
>> +
>> +    if (!nvdimm) {
>> +        goto exit;
>> +    }
>> +
>> +    status = NFIT_STATUS_SUCCESS;
>> +    out->cmd_config_size.config_size = nvdimm->config_data_size;
>> +    out->cmd_config_size.max_xfer = max_xfer_config_size();
>
> cpu_to_*() missing?
>
> It should be possible to emulate NVDIMMs for a x86_64 guest on a
> big-endian host, for example.

Indeed, will fix it in the next version, thank you for pointing it out.