From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54453) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAunX-0001Gj-UC for qemu-devel@nongnu.org; Fri, 03 Jul 2015 02:50:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAunU-0007rt-Ou for qemu-devel@nongnu.org; Fri, 03 Jul 2015 02:50:07 -0400 Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:38363) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAunU-0007oM-Hh for qemu-devel@nongnu.org; Fri, 03 Jul 2015 02:50:04 -0400 Received: by wibdq8 with SMTP id dq8so91699572wib.1 for ; Thu, 02 Jul 2015 23:50:03 -0700 (PDT) Sender: Paolo Bonzini References: <1433812331-18993-1-git-send-email-minyard@acm.org> From: Paolo Bonzini Message-ID: <55963098.8020505@redhat.com> Date: Fri, 3 Jul 2015 08:50:00 +0200 MIME-Version: 1.0 In-Reply-To: <1433812331-18993-1-git-send-email-minyard@acm.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 00/16] Add an IPMI device to QEMU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: minyard@acm.org, qemu-devel@nongnu.org, "Michael S. Tsirkin" On 09/06/2015 03:11, minyard@acm.org wrote: > I have reworked the QEMU IPMI patches, and I believe this design > improves greatly on the previous one. The suggestions made all > resulted in better design. To start an IPMI interface > with this, you would use: > > -device ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0 > > Note that I did not make the BMCs objects. I started this way, but > adding properties was ending up duplicating a lot of code already > in the device core, especially for the chardev link. > > I'm not sure of the importance of having a BMC be an object instead > of a device, but it seems to me that if we do that, it would be > best to add helper functions to the object core for the chardev > and integer properties. Hi, sorry for the delay. I missed this because I left for vacation exactly on the day it was posted. I think it's okay to have it as a device. Michael, are you going to merge it? Otherwise, just ack the patches and I will take care of it. Time is ticking fast... Paolo