From: John Snow <jsnow@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [RFC 08/10] fdc: refactor pick_geometry
Date: Sat, 04 Jul 2015 01:40:26 -0400 [thread overview]
Message-ID: <559771CA.2010008@redhat.com> (raw)
In-Reply-To: <87bnft5p86.fsf@blackfin.pond.sub.org>
On 07/03/2015 09:45 AM, Markus Armbruster wrote:
> John Snow <jsnow@redhat.com> writes:
>
>> This one is the crazy one.
>
> I'm afraid I don't have the mental capacity to properly review this one
> right now.
>
> From what I've understood of your series so far, it's a strict decrease
> of fdc craziness. Thanks!
>
Yup, this is the one that definitely changes the behavior a little, and
the hard part in reviewing this is (I hope) understanding how the old
code works.
Hopefully the new version is a little more explicit in how it guesses.
Thanks again for looking.
--js
next prev parent reply other threads:[~2015-07-04 5:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 1:20 [Qemu-devel] [RFC 00/10] fix 2.88mb floppy diskette support John Snow
2015-07-01 1:20 ` [Qemu-devel] [RFC 01/10] fdc: Make default FDrive type explicit John Snow
2015-07-01 1:20 ` [Qemu-devel] [RFC 02/10] fdc: add default drive type option John Snow
2015-07-03 13:18 ` Markus Armbruster
2015-07-04 5:34 ` John Snow
2015-07-04 6:48 ` Markus Armbruster
2015-07-03 13:21 ` Markus Armbruster
2015-07-01 1:20 ` [Qemu-devel] [RFC 03/10] fdc: respect default drive type John Snow
2015-07-03 13:34 ` Markus Armbruster
2015-07-04 5:49 ` John Snow
2015-07-04 6:47 ` Markus Armbruster
2015-07-06 15:52 ` John Snow
2015-07-22 15:00 ` Markus Armbruster
2015-07-01 1:20 ` [Qemu-devel] [RFC 04/10] fdc: move pick_geometry John Snow
2015-07-01 1:20 ` [Qemu-devel] [RFC 05/10] fdc: refactor pick_geometry John Snow
2015-07-03 13:36 ` Markus Armbruster
2015-07-01 1:20 ` [Qemu-devel] [RFC 06/10] fdc: add physical disk sizes John Snow
2015-07-03 13:38 ` Markus Armbruster
2015-07-04 5:39 ` John Snow
2015-07-01 1:20 ` [Qemu-devel] [RFC 07/10] fdc: add disk field John Snow
2015-07-01 1:20 ` [Qemu-devel] [RFC 08/10] fdc: refactor pick_geometry John Snow
2015-07-03 13:45 ` Markus Armbruster
2015-07-04 5:40 ` John Snow [this message]
2015-07-01 1:20 ` [Qemu-devel] [RFC 09/10] qtest/fdc: Support for 2.88MB drives John Snow
2015-07-01 1:20 ` [Qemu-devel] [RFC 10/10] fdc: change default drive to 288 John Snow
2015-07-05 14:53 ` Kevin O'Connor
2015-07-06 12:41 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559771CA.2010008@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).