From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZBGBl-0001ic-Ee for qemu-devel@nongnu.org; Sat, 04 Jul 2015 01:40:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZBGBk-0007PP-4J for qemu-devel@nongnu.org; Sat, 04 Jul 2015 01:40:33 -0400 Message-ID: <559771CA.2010008@redhat.com> Date: Sat, 04 Jul 2015 01:40:26 -0400 From: John Snow MIME-Version: 1.0 References: <1435713640-12362-1-git-send-email-jsnow@redhat.com> <1435713640-12362-9-git-send-email-jsnow@redhat.com> <87bnft5p86.fsf@blackfin.pond.sub.org> In-Reply-To: <87bnft5p86.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 08/10] fdc: refactor pick_geometry List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org On 07/03/2015 09:45 AM, Markus Armbruster wrote: > John Snow writes: > >> This one is the crazy one. > > I'm afraid I don't have the mental capacity to properly review this one > right now. > > From what I've understood of your series so far, it's a strict decrease > of fdc craziness. Thanks! > Yup, this is the one that definitely changes the behavior a little, and the hard part in reviewing this is (I hope) understanding how the old code works. Hopefully the new version is a little more explicit in how it guesses. Thanks again for looking. --js