From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42892)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <digetx@gmail.com>) id 1ZBTa1-0004hu-0k
	for qemu-devel@nongnu.org; Sat, 04 Jul 2015 15:58:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <digetx@gmail.com>) id 1ZBTZv-0005gE-Qq
	for qemu-devel@nongnu.org; Sat, 04 Jul 2015 15:58:28 -0400
Received: from mail-la0-x229.google.com ([2a00:1450:4010:c03::229]:33514)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <digetx@gmail.com>) id 1ZBTZv-0005fa-IQ
	for qemu-devel@nongnu.org; Sat, 04 Jul 2015 15:58:23 -0400
Received: by laar3 with SMTP id r3so116385288laa.0
	for <qemu-devel@nongnu.org>; Sat, 04 Jul 2015 12:58:21 -0700 (PDT)
Message-ID: <55983AD7.2030700@gmail.com>
Date: Sat, 04 Jul 2015 22:58:15 +0300
From: Dmitry Osipenko <digetx@gmail.com>
MIME-Version: 1.0
References: <1435877531-24983-1-git-send-email-digetx@gmail.com>	<1435877531-24983-4-git-send-email-digetx@gmail.com>
	<CAEgOgz54J9Dkt4kV7Ef1g4SSMR8hrPtWeuAmSuaXrvtEK4Z7+A@mail.gmail.com>
In-Reply-To: <CAEgOgz54J9Dkt4kV7Ef1g4SSMR8hrPtWeuAmSuaXrvtEK4Z7+A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 3/3] arm_mptimer: Respect IT bit state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>

Hello Peter,

04.07.2015 22:39, Peter Crosthwaite пишет:
>
> You also need to trigger timerblock_update_irq on change of state for
> the control bit itself. "case 8: /* Control.  */" in the _write
> handler needs to call this fn.
>

Right, as it will mask/unmask interrupt line. Good catch, thanks.

-- 
Dmitry