From: Dmitry Osipenko <digetx@gmail.com>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org,
Peter Crosthwaite <crosthwaite.peter@gmail.com>
Subject: Re: [Qemu-devel] [RFC v1 0/2] ARM MPTimer fixes and refactoring
Date: Sun, 05 Jul 2015 23:47:55 +0300 [thread overview]
Message-ID: <559997FB.4030301@gmail.com> (raw)
In-Reply-To: <1436128000-16262-1-git-send-email-crosthwaite.peter@gmail.com>
05.07.2015 23:26, Peter Crosthwaite пишет:
> Hi Dmitry,
>
> Based on my comment earlier, this is what I came up with RE consolidation of
> those arm_mptimer code paths that were giving you problems. I have not done the
> interrupt mask fix, as that one from your series is reasonably independent.
>
> Regards,
> Peter
>
> Peter Crosthwaite (2):
> timer: arm_mp: Factor out timer value calculation
> timer: arm_mp: consolidate control and counter write logic
>
> hw/timer/arm_mptimer.c | 73 +++++++++++++++++++++++++++++---------------------
> 1 file changed, 42 insertions(+), 31 deletions(-)
>
Hi Peter, thanks a lot! Generally, I don't have any trouble with currently
missed functionality, just noticed it while was hacking my NVIDIA Tegra2
emulation pet-project and decided to contribute =).
It looks like you are trying to duplicate what generic ptimer is already doing,
isn't it?
--
Dmitry
next prev parent reply other threads:[~2015-07-05 20:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-05 20:26 [Qemu-devel] [RFC v1 0/2] ARM MPTimer fixes and refactoring Peter Crosthwaite
2015-07-05 20:26 ` [Qemu-devel] [RFC v1 1/2] timer: arm_mp: Factor out timer value calculation Peter Crosthwaite
2015-07-05 20:26 ` [Qemu-devel] [RFC v1 2/2] timer: arm_mp: consolidate control and counter write logic Peter Crosthwaite
2015-07-05 20:47 ` Dmitry Osipenko [this message]
2015-07-05 20:58 ` [Qemu-devel] [RFC v1 0/2] ARM MPTimer fixes and refactoring Peter Crosthwaite
2015-07-05 21:01 ` Peter Crosthwaite
2015-07-05 21:06 ` Peter Maydell
2015-07-05 21:12 ` Peter Crosthwaite
2015-07-05 21:21 ` Dmitry Osipenko
2015-09-20 17:48 ` Peter Crosthwaite
2015-10-03 13:11 ` Dmitry Osipenko
2015-10-05 16:07 ` Dmitry Osipenko
2015-10-05 16:27 ` Peter Crosthwaite
2015-10-05 16:43 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559997FB.4030301@gmail.com \
--to=digetx@gmail.com \
--cc=crosthwaite.peter@gmail.com \
--cc=crosthwaitepeter@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).